Issue 493443004: Add some SkTextBlob builder tests.

Issue 493443004: Add some SkTextBlob builder tests. (Closed)

Created:
6 years, 4 months ago by f(malita)

Modified:
6 years, 4 months ago

Reviewers:
robertphillips, reed1

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Project:
skia

Visibility:
Public.

More Reviews

Description

Add some SkTextBlob builder tests. R=robertphillips@google.com,reed@google.com Committed: https://skia.googlesource.com/skia/+/c6765d69e3aceaa316fe2d2ef00a7f0d138def2f

Patch Set 2 : win build fix #

Total comments: 14

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+194 lines, -0 lines)			Patch
M	gyp/tests.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	include/core/SkTextBlob.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	tests/TextBlobTest.cpp	View	1	1 chunk	+192 lines, -0 lines	14 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/fmalita@chromium.org/493443004/10004

6 years, 4 months ago (2014-08-21 21:54:44 UTC) #4

commit-bot: I haz the power

Committed patchset #2 (10004) as c6765d69e3aceaa316fe2d2ef00a7f0d138def2f

6 years, 4 months ago (2014-08-21 22:03:09 UTC) #5

robertphillips

https://codereview.chromium.org/493443004/diff/10004/tests/TextBlobTest.cpp File tests/TextBlobTest.cpp (right): https://codereview.chromium.org/493443004/diff/10004/tests/TextBlobTest.cpp#newcode14 tests/TextBlobTest.cpp:14: // This unit test feeds the TextBlob builder various ...

6 years, 4 months ago (2014-08-22 12:01:47 UTC) #6

f(malita)

6 years, 4 months ago (2014-08-22 13:23:59 UTC) #7

Message was sent while issue was closed.

Thanks Robert, will land these with a different CL.

https://codereview.chromium.org/493443004/diff/10004/tests/TextBlobTest.cpp
File tests/TextBlobTest.cpp (right):

https://codereview.chromium.org/493443004/diff/10004/tests/TextBlobTest.cpp#n...
tests/TextBlobTest.cpp:14: 
On 2014/08/22 12:01:47, robertphillips wrote:
> // This unit test feeds the TextBlob builder various runs then checks to see
if
> the result contains the provided data and merges runs when appropriate ?

Done.

https://codereview.chromium.org/493443004/diff/10004/tests/TextBlobTest.cpp#n...
tests/TextBlobTest.cpp:16: public:
On 2014/08/22 12:01:47, robertphillips wrote:
> TestBuilder ?

Done.

https://codereview.chromium.org/493443004/diff/10004/tests/TextBlobTest.cpp#n...
tests/TextBlobTest.cpp:17: static void test_builder(skiatest::Reporter*
reporter) {
On 2014/08/22 12:01:47, robertphillips wrote:
> Defer creation of font & builder to runBuilderTest to reduce parameter passing
?

Done for font. I'd prefer to keep the same builder, to also exercise its
reusability.

https://codereview.chromium.org/493443004/diff/10004/tests/TextBlobTest.cpp#n...
tests/TextBlobTest.cpp:25: 
On 2014/08/22 12:01:47, robertphillips wrote:
> set* ?

Done.

https://codereview.chromium.org/493443004/diff/10004/tests/TextBlobTest.cpp#n...
tests/TextBlobTest.cpp:56: };
On 2014/08/22 12:01:47, robertphillips wrote:
> mergedSet* ?

Done.

https://codereview.chromium.org/493443004/diff/10004/tests/TextBlobTest.cpp#n...
tests/TextBlobTest.cpp:110: 
On 2014/08/22 12:01:47, robertphillips wrote:
> RunBuilderTest ?

Done.

https://codereview.chromium.org/493443004/diff/10004/tests/TextBlobTest.cpp#n...
tests/TextBlobTest.cpp:156: 
On 2014/08/22 12:01:47, robertphillips wrote:
> AddRun ?

Done.

Expand Messages | Collapse Messages