Fix runtime error in copytree() MockFileSystem

Fix runtime error in copytree() MockFileSystem

We are iterating over a list and modifying the same list within the loop which causes a RunTimeError.
Iterate over keys instead of the list itself to prevent this.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181177

[patro, 2014-08-22 08:24:30]

Kindly Review

Thanks,
Shyam Patro

[vivekg, 2014-08-22 08:48:09]

https://codereview.chromium.org/493413002/diff/1/Tools/Scripts/webkitpy/commo...
File Tools/Scripts/webkitpy/common/system/filesystem_mock.py (right):

https://codereview.chromium.org/493413002/diff/1/Tools/Scripts/webkitpy/commo...
Tools/Scripts/webkitpy/common/system/filesystem_mock.py:394: #Have to make a
copy because we are modifying the list within the loop
nit: space after '#'

https://codereview.chromium.org/493413002/diff/1/Tools/Scripts/webkitpy/commo...
Tools/Scripts/webkitpy/common/system/filesystem_mock.py:396: for source_file in
file_list:
or could be `for source_file in self.files.keys():`

[vivekg, 2014-08-22 08:48:34]

On 2014/08/22 at 08:24:30, behara.ms wrote:
> Kindly Review
> 
> Thanks,
> Shyam Patro

Please add a unit test case to verify this behavior.

[patro, 2014-08-22 09:28:28]

PTAL

Thanks,
Shyam Patro

https://codereview.chromium.org/493413002/diff/1/Tools/Scripts/webkitpy/commo...
File Tools/Scripts/webkitpy/common/system/filesystem_mock.py (right):

https://codereview.chromium.org/493413002/diff/1/Tools/Scripts/webkitpy/commo...
Tools/Scripts/webkitpy/common/system/filesystem_mock.py:394: #Have to make a
copy because we are modifying the list within the loop
On 2014/08/22 08:48:09, vivekg_ wrote:
> nit: space after '#'

Done.

https://codereview.chromium.org/493413002/diff/1/Tools/Scripts/webkitpy/commo...
Tools/Scripts/webkitpy/common/system/filesystem_mock.py:396: for source_file in
file_list:
On 2014/08/22 08:48:09, vivekg_ wrote:
> or could be `for source_file in self.files.keys():`

Done.

[vivekg, 2014-08-22 10:12:24]

thanks, lgtm! Lets wait for @dpranke's comments.

[Dirk Pranke, 2014-08-27 23:42:45]

lgtm.

https://codereview.chromium.org/493413002/diff/60001/Tools/Scripts/webkitpy/c...
File Tools/Scripts/webkitpy/common/system/filesystem_mock.py (right):

https://codereview.chromium.org/493413002/diff/60001/Tools/Scripts/webkitpy/c...
Tools/Scripts/webkitpy/common/system/filesystem_mock.py:394: for source_file in
self.files.keys():
this change is fine for Python 2.7, but I think it will have the same problem in
python 3 that the 'for ... in dict' old version does, so it might be better to 
change this to "for source_file in list(self.files)", which is safe in Python 3.

Not that we actually support Python 3 yet, of course ...

[patro, 2014-09-01 09:14:02]

https://codereview.chromium.org/493413002/diff/60001/Tools/Scripts/webkitpy/c...
File Tools/Scripts/webkitpy/common/system/filesystem_mock.py (right):

https://codereview.chromium.org/493413002/diff/60001/Tools/Scripts/webkitpy/c...
Tools/Scripts/webkitpy/common/system/filesystem_mock.py:394: for source_file in
self.files.keys():
On 2014/08/27 23:42:45, Dirk Pranke wrote:
> this change is fine for Python 2.7, but I think it will have the same problem
in
> python 3 that the 'for ... in dict' old version does, so it might be better to

> change this to "for source_file in list(self.files)", which is safe in Python
3.
> 
> Not that we actually support Python 3 yet, of course ...

Done.

[patro, 2014-09-01 09:14:09]

The CQ bit was checked by behara.ms@samsung.com

[commit-bot: I haz the power, 2014-09-01 09:15:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/behara.ms@samsung.com/493413002/80001

[commit-bot: I haz the power, 2014-09-01 10:17:45]

Committed patchset #5 (id:80001) as 181177