[Autofill] Autofill incorrectly fills credit card expiration year in 2-digit fields.

components/autofill/core/browser/credit_card_field.cc

Index: components/autofill/core/browser/credit_card_field.cc
diff --git a/components/autofill/core/browser/credit_card_field.cc b/components/autofill/core/browser/credit_card_field.cc
index 09dab1e48d796800fda5065ee6cb54075fd5697a..976ee392fca01530399e6d982cbb3c30674adac6 100644
--- a/components/autofill/core/browser/credit_card_field.cc
+++ b/components/autofill/core/browser/credit_card_field.cc
@@ -107,6 +107,8 @@ FormField* CreditCardField::Parse(AutofillScanner* scanner) {
         pattern = base::UTF8ToUTF16(autofill::kExpirationYearRe);
         if (ParseFieldSpecifics(scanner, pattern, MATCH_DEFAULT | MATCH_SELECT,
                                  &credit_card_field->expiration_year_)) {

[Evan Stade, 2014/08/22 17:30:18]

nit: could you fix the indent here

[Pritam Nikam, 2014/08/23 08:27:35]

Done.

Applied git cl format on entire content.

+          if (credit_card_field->expiration_year_->max_length == 2)
+            credit_card_field->is_two_digit_year_ = true;

[Evan Stade, 2014/08/22 17:30:18]

I kinda think a more general way to tackle this (more robust to future changes)
would be to create a function:

bool IsTwoDigitYear() {
  return is_two_digit_year_ || (expiration_year_ && expiration_year_->max_length
== 2);
}

And use that instead of checking is_two_digit_year_. That seems like it would be
more robust to future changes or additions to the code...

Also maybe switch the member var from

  bool is_two_digit_year_;

to

  ServerFieldType exp_year_type_;

Then the function above becomes

ServerFieldType GetExpirationYearType()

I think this makes the calling site cleaner.

[Pritam Nikam, 2014/08/23 08:27:35]

+1
Added,
ServerFieldType GetExpirationYearType() const;

ServerFieldType exp_year_type_;

           continue;
         }
       }