Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Unified Diff: chrome/browser/resources/options/website_settings_edit_page.js

Issue 493383004: Add a button to clear local storage for a given origin to Website Settings dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Whoops. Forgot to commit these changes. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/website_settings_edit_page.js
diff --git a/chrome/browser/resources/options/website_settings_edit_page.js b/chrome/browser/resources/options/website_settings_edit_page.js
index d19cf0d2188917c823064ff8698a151ddbb1bb6c..2c9f46abce470228912e42b09ac74a16e4a3540c 100644
--- a/chrome/browser/resources/options/website_settings_edit_page.js
+++ b/chrome/browser/resources/options/website_settings_edit_page.js
@@ -29,6 +29,10 @@ cr.define('options.WebsiteSettings', function() {
initializePage: function() {
Page.prototype.initializePage.call(this);
+ $('websiteSettingsStorageDeleteButton').onclick = function(event) {
+ chrome.send('deleteLocalStorage');
+ };
+
$('websiteSettingsEditorCancelButton').onclick =
PageManager.closeOverlay.bind(PageManager);
@@ -58,9 +62,10 @@ cr.define('options.WebsiteSettings', function() {
* @param {string} local_storage A string describing the local storage use.
* @param {Object} permissions A dictionary of permissions to their
* available and current settings, and if it is editable.
+ * @param {boolean} show_page If the page should raised.
* @private
*/
- populateOrigin_: function(local_storage, permissions) {
+ populateOrigin_: function(local_storage, permissions, show_page) {
Bernhard Bauer 2014/08/22 20:42:38 This should be named showPage (same goes for local
Daniel Nishi 2014/08/22 21:45:25 Done.
$('local-storage-title').textContent = local_storage;
for (var key in permissions) {
var selector = $(key + '-select-option');
@@ -77,7 +82,8 @@ cr.define('options.WebsiteSettings', function() {
selector.originalValue = permissions[key].setting;
selector.disabled = !permissions[key].editable;
}
- PageManager.showPageByName('websiteEdit', false);
+ if (show_page)
+ PageManager.showPageByName('websiteEdit', false);
},
updatePermissions: function() {
@@ -91,9 +97,11 @@ cr.define('options.WebsiteSettings', function() {
},
};
- WebsiteSettingsEditor.populateOrigin = function(local_storage, permissions) {
+ WebsiteSettingsEditor.populateOrigin = function(local_storage, permissions,
+ show_page) {
WebsiteSettingsEditor.getInstance().populateOrigin_(local_storage,
- permissions);
+ permissions,
+ show_page);
};
// Export

Powered by Google App Engine
This is Rietveld 408576698