content/browser/service_worker/service_worker_fetch_dispatcher.h - Issue 493373002: ServiceWorker: Add prepare_callback in DispatchFetchEvent to notify the end of SW preparation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_fetch_dispatcher.h

Issue 493373002: ServiceWorker: Add prepare_callback in DispatchFetchEvent to notify the end of SW preparation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Incorporate the reviewers comment Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_fetch_dispatcher.cc » ('j') | content/browser/service_worker/service_worker_fetch_dispatcher.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_fetch_dispatcher.h

diff --git a/content/browser/service_worker/service_worker_fetch_dispatcher.h b/content/browser/service_worker/service_worker_fetch_dispatcher.h

index 7b905e0b35d7fe5cc78d473f70b9dbad4d5d4cdd..f20fb9495487bb3d38723c953c9811c9fe21c6e5 100644

--- a/content/browser/service_worker/service_worker_fetch_dispatcher.h

+++ b/content/browser/service_worker/service_worker_fetch_dispatcher.h

@@ -24,7 +24,8 @@ class ServiceWorkerFetchDispatcher {

ServiceWorkerFetchDispatcher(scoped_ptr<ServiceWorkerFetchRequest> request,

ServiceWorkerVersion* version,

- const FetchCallback& callback);

+ const base::Closure& prepare_callback,

+ const FetchCallback& fetch_callback);

~ServiceWorkerFetchDispatcher();

// Dispatches a fetch event to the |version| given in ctor, and fires

@@ -35,12 +36,14 @@ class ServiceWorkerFetchDispatcher {

void DidWaitActivation();

void DidFailActivation();

void DispatchFetchEvent();

+ void DidPrepare();

void DidFinish(ServiceWorkerStatusCode status,

ServiceWorkerFetchEventResult fetch_result,

const ServiceWorkerResponse& response);

scoped_refptr<ServiceWorkerVersion> version_;

- FetchCallback callback_;

+ base::Closure prepare_callback_;

+ FetchCallback fetch_callback_;

scoped_ptr<ServiceWorkerFetchRequest> request_;

base::WeakPtrFactory<ServiceWorkerFetchDispatcher> weak_factory_;