Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 493363005: Roll ICU to 291660 (Closed)

Created:
6 years, 3 months ago by jungshik at Google
Modified:
6 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Roll ICU to 291660 Rolled src/third_party/icu from revision fdf0bb34eaddce23811770b987ecf95ee18572d6 to revision a4ce5bf56788dbb4835a5ef6143384266bbff5f5 Summary of changes available at: https://chromium.googlesource.com/chromium/deps/icu52/+log/fdf0bb34eadd..a4ce5bf56788 TBR=thakis@chromium.org BUG=82385 TEST=Build on Windows with clang and the above warning is not emitted while building ICU Committed: https://crrev.com/a3a8c58ea4af6cca7d2a0d697c196c24fb02bbbc Cr-Commit-Position: refs/heads/master@{#292049}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
jungshik at Google
Adding to CQ
6 years, 3 months ago (2014-08-26 23:03:24 UTC) #1
jungshik at Google
The CQ bit was checked by jshin@chromium.org
6 years, 3 months ago (2014-08-26 23:03:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jshin@chromium.org/493363005/1
6 years, 3 months ago (2014-08-26 23:04:33 UTC) #3
Nico
lgtm, thanks!
6 years, 3 months ago (2014-08-26 23:08:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (1) as 5c7fdd5d7fab8bf1422d58933501351e5dc9001f
6 years, 3 months ago (2014-08-27 00:21:23 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:48:03 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a3a8c58ea4af6cca7d2a0d697c196c24fb02bbbc
Cr-Commit-Position: refs/heads/master@{#292049}

Powered by Google App Engine
This is Rietveld 408576698