chrome/common/extensions/permissions/permissions_data.cc - Issue 49333004: Make app APIs implicit within _api_features.json not _permission_features.json.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/permissions_data.cc

Issue 49333004: Make app APIs implicit within _api_features.json not _permission_features.json. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix messaging test Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/permissions/permission_set_unittest.cc ('k') | chrome/test/data/extensions/platform_apps/messaging/app2/manifest.json » ('j') | chrome/test/data/extensions/platform_apps/messaging/app2/manifest.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/permissions_data.cc

diff --git a/chrome/common/extensions/permissions/permissions_data.cc b/chrome/common/extensions/permissions/permissions_data.cc

index d6fb529425e7ed075be58dca0cc3ac99f7bd62ea..3e682f030c0c7872327d549ce668abfc3633f5a0 100644

--- a/chrome/common/extensions/permissions/permissions_data.cc

+++ b/chrome/common/extensions/permissions/permissions_data.cc

@@ -582,18 +582,6 @@ bool PermissionsData::ParsePermissions(Extension* extension, string16* error) {

return false;

}

- // TODO(jeremya/kalman) do this via the features system by exposing the

- // app.window API to platform apps, with no dependency on any permissions.

- // See http://crbug.com/120069.

- if (extension->is_platform_app()) {

- initial_required_permissions_->api_permissions.insert(

- APIPermission::kAppCurrentWindowInternal);

- initial_required_permissions_->api_permissions.insert(

- APIPermission::kAppRuntime);

- initial_required_permissions_->api_permissions.insert(

- APIPermission::kAppWindow);

- }

initial_optional_permissions_.reset(new InitialPermissions);

if (!ParseHelper(extension,

keys::kOptionalPermissions,