Enable invalidations for supervised user settings on Android.

Enable invalidations for supervised user settings on Android.

BUG=none

Committed: https://crrev.com/dab6c6fa3c31a2675db949d36274396abfbcb068
Cr-Commit-Position: refs/heads/master@{#292353}

[Bernhard Bauer, 2014-08-22 00:25:00]

Please review.

[Nicolas Zea, 2014-08-22 00:28:22]

Is there any test we can add that will fail if a ModelType is added without
updating these spots? These are easily forgotten, so would be good to prevent it
in the future.

+Tommy, in case he knows of a good spot to test this.

[Bernhard Bauer, 2014-08-27 18:45:21]

Added a unit test. PTAL?

[Nicolas Zea, 2014-08-27 19:46:59]

LG with one comment

https://codereview.chromium.org/493293002/diff/60001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_service_android_unittest.cc (right):

https://codereview.chromium.org/493293002/diff/60001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_service_android_unittest.cc:82:
syncer::ModelTypeSet model_types = GetRegisteredDataTypes();
nit: I think you can probably use syncer::ProtocolTypes() here instead of
GetRegisteredDataTypes. That way we catch datatypes that are still off by
default before they're turned on.

[Bernhard Bauer, 2014-08-27 20:46:12]

https://codereview.chromium.org/493293002/diff/60001/chrome/browser/sync/prof...
File chrome/browser/sync/profile_sync_service_android_unittest.cc (right):

https://codereview.chromium.org/493293002/diff/60001/chrome/browser/sync/prof...
chrome/browser/sync/profile_sync_service_android_unittest.cc:82:
syncer::ModelTypeSet model_types = GetRegisteredDataTypes();
On 2014/08/27 19:46:59, Nicolas Zea wrote:
> nit: I think you can probably use syncer::ProtocolTypes() here instead of
> GetRegisteredDataTypes. That way we catch datatypes that are still off by
> default before they're turned on.

That's what I did initially, but the problem with that is that there are a lot
of data types that actually are turned off on Android, so I would have to
manually remove them.

[Nicolas Zea, 2014-08-27 20:53:14]

On 2014/08/27 20:46:12, Bernhard Bauer wrote:
>
https://codereview.chromium.org/493293002/diff/60001/chrome/browser/sync/prof...
> File chrome/browser/sync/profile_sync_service_android_unittest.cc (right):
> 
>
https://codereview.chromium.org/493293002/diff/60001/chrome/browser/sync/prof...
> chrome/browser/sync/profile_sync_service_android_unittest.cc:82:
> syncer::ModelTypeSet model_types = GetRegisteredDataTypes();
> On 2014/08/27 19:46:59, Nicolas Zea wrote:
> > nit: I think you can probably use syncer::ProtocolTypes() here instead of
> > GetRegisteredDataTypes. That way we catch datatypes that are still off by
> > default before they're turned on.
> 
> That's what I did initially, but the problem with that is that there are a lot
> of data types that actually are turned off on Android, so I would have to
> manually remove them.

Hmm, right. On the one hand I kind of do think that the dev should have to make
the explicit decision to not be syncing on mobile, but I guess they already do
that in the components factory. LGTM then

[Bernhard Bauer, 2014-08-27 22:12:39]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2014-08-27 22:14:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bauerb@chromium.org/493293002/60001

[commit-bot: I haz the power, 2014-08-27 23:40:34]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2014-08-27 23:47:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-27 23:47:29]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)

[Bernhard Bauer, 2014-08-28 00:17:09]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2014-08-28 00:27:30]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bauerb@chromium.org/493293002/80001

[commit-bot: I haz the power, 2014-08-28 05:04:03]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[commit-bot: I haz the power, 2014-08-28 05:08:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-28 05:08:56]

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)

[Bernhard Bauer, 2014-08-28 08:34:06]

The CQ bit was checked by bauerb@chromium.org

[commit-bot: I haz the power, 2014-08-28 08:35:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/bauerb@chromium.org/493293002/100001

[commit-bot: I haz the power, 2014-08-28 09:20:30]

Committed patchset #6 (id:100001) as 4889a1ec371d40bb02eae0fd08c5986b2cd2fed8

[nyquist, 2014-08-28 15:03:34]

nyquist@chromium.org changed reviewers:
+ nyquist@chromium.org

[nyquist, 2014-08-28 15:03:34]

Just saw this.

https://codereview.chromium.org/493293002/diff/100001/sync/android/java/src/o...
File
sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java
(right):

https://codereview.chromium.org/493293002/diff/100001/sync/android/java/src/o...
sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java:93:
assert nonInvalidationType || modelType == toString();
Never compare two strings in Java using ==, use .equals instead. When you do
this, you also must know that the left value is non-null.
Also, use name() instead of to string().
So:
name().equals(modelType)

[Bernhard Bauer, 2014-08-28 15:16:47]

https://codereview.chromium.org/493293002/diff/100001/sync/android/java/src/o...
File
sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java
(right):

https://codereview.chromium.org/493293002/diff/100001/sync/android/java/src/o...
sync/android/java/src/org/chromium/sync/internal_api/pub/base/ModelType.java:93:
assert nonInvalidationType || modelType == toString();
On 2014/08/28 15:03:34, nyquist wrote:
> Never compare two strings in Java using ==, use .equals instead. When you do
> this, you also must know that the left value is non-null.
> Also, use name() instead of to string().
> So:
> name().equals(modelType)

Done, see https://codereview.chromium.org/511253002. I had already fixed the ==
part in https://codereview.chromium.org/517453003/.

[commit-bot: I haz the power, 2014-09-10 02:58:38]

Patchset 6 (id:??) landed as
https://crrev.com/dab6c6fa3c31a2675db949d36274396abfbcb068
Cr-Commit-Position: refs/heads/master@{#292353}