Chromium Code Reviews

Issue 493283003: Property propagation to anonymous children only needed by old multicol. (Closed)

Created:
6 years, 3 months ago by mstensho (USE GERRIT)
Modified:
6 years, 2 months ago
Reviewers:
leviw_travelin_and_unemployed, esprehn, rune, Julien - ping for review
CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, pdr., rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Property propagation to anonymous children only needed by old multicol. The new (flowthread based) multicol implementation has no need for this. Although it IS harmless to propagate this for new multicol, better add a check, so that we remember to get rid of this code once we remove the old multicol implementation. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182748

Patch Set 1 #

Unified diffs Side-by-side diffs Stats (+7 lines, -5 lines)
M Source/core/rendering/RenderObject.cpp View 1 chunk +7 lines, -5 lines 0 comments

Messages

Total messages: 11 (2 generated)
mstensho (USE GERRIT)
mstensho@opera.com changed reviewers: + leviw@chromium.org
6 years, 3 months ago (2014-08-26 11:26:19 UTC) #1
mstensho (USE GERRIT)
6 years, 3 months ago (2014-08-26 11:26:19 UTC) #2
mstensho (USE GERRIT)
mstensho@opera.com changed reviewers: + esprehn@chromium.org, jchaffraix@chromium.org
6 years, 3 months ago (2014-08-27 10:14:30 UTC) #3
mstensho (USE GERRIT)
6 years, 3 months ago (2014-08-27 10:14:30 UTC) #4
mstensho (USE GERRIT)
6 years, 2 months ago (2014-09-25 06:32:48 UTC) #5
rune
lgtm
6 years, 2 months ago (2014-09-25 11:05:11 UTC) #7
rune
On 2014/09/25 11:05:11, rune wrote: > lgtm The first line of the description is a ...
6 years, 2 months ago (2014-09-25 11:07:05 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/493283003/1
6 years, 2 months ago (2014-09-26 08:35:43 UTC) #10
commit-bot: I haz the power
6 years, 2 months ago (2014-09-26 09:39:03 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 182748

Powered by Google App Engine