Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: net/base/net_util_icu_unittest.cc

Issue 493253003: Adds default port handling to FormatUrl. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« net/base/net_util_icu.cc ('K') | « net/base/net_util_icu.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/net_util_icu_unittest.cc
diff --git a/net/base/net_util_icu_unittest.cc b/net/base/net_util_icu_unittest.cc
index 9beb4349b57d6fcffd78df70d564e387f30bb2a3..c88bda19dcf7013d5f935ee0fb1464b7df80408f 100644
--- a/net/base/net_util_icu_unittest.cc
+++ b/net/base/net_util_icu_unittest.cc
@@ -641,6 +641,36 @@ TEST(NetUtilTest, FormatUrl) {
UnescapeRule::NORMAL, L"http://ftp.google.com/",
7},
+ // -------- omit default port --------
+ {"handle no port to begin with",
+ "http://www.google.com/", "en",
+ kFormatUrlOmitDefaultPort, UnescapeRule::NORMAL,
+ L"http://www.google.com/", 7},
+ {"omit default port for http -> 80",
+ "http://www.google.com:80/", "en",
+ kFormatUrlOmitDefaultPort, UnescapeRule::NORMAL,
+ L"http://www.google.com/", 7},
+ {"leave port for http -> 81",
+ "http://www.google.com:81/", "en",
+ kFormatUrlOmitDefaultPort, UnescapeRule::NORMAL,
+ L"http://www.google.com:81/", 7},
+ {"omit port for https -> 443",
+ "https://www.google.com:443/", "en",
+ kFormatUrlOmitDefaultPort, UnescapeRule::NORMAL,
+ L"https://www.google.com/", 8},
+ {"leave port for https -> 80",
+ "https://www.google.com:80/", "en",
+ kFormatUrlOmitDefaultPort, UnescapeRule::NORMAL,
+ L"https://www.google.com:80/", 8},
+ {"omit port for ftp -> 21",
+ "ftp://www.google.com:21/", "en",
+ kFormatUrlOmitDefaultPort, UnescapeRule::NORMAL,
+ L"ftp://www.google.com/", 6},
+ {"leave port for ftp -> 40",
+ "ftp://www.google.com:40/", "en",
+ kFormatUrlOmitDefaultPort, UnescapeRule::NORMAL,
+ L"ftp://www.google.com:40/", 6},
+
// -------- omit trailing slash on bare hostname --------
{"omit slash when it's the entire path",
"http://www.google.com/", "en",
« net/base/net_util_icu.cc ('K') | « net/base/net_util_icu.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698