Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 493213002: Don't use <(DEPTH) in the argument to the -include flag. (Closed)

Created:
6 years, 4 months ago by wtc
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Don't use <(DEPTH) in the argument to the -include flag. Instead, pass just the file name to -include. Add the nss_ prefix to the file name (build_config_mac.h) to make the name more unique. R=mark@chromium.org,kjellander@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291588

Patch Set 1 #

Patch Set 2 : Pass just the file name to -include. Rename build_config_mac.h with nss_ prefix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -44 lines) Patch
M README.chromium View 1 1 chunk +3 lines, -3 lines 0 comments Download
M nss.gyp View 1 3 chunks +2 lines, -2 lines 0 comments Download
D nss/lib/freebl/build_config_mac.h View 1 1 chunk +0 lines, -40 lines 0 comments Download
A + nss/lib/freebl/nss_build_config_mac.h View 1 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
wtc
Please review. The code in question was added in https://chromiumcodereview.appspot.com/10828060
6 years, 4 months ago (2014-08-21 21:42:08 UTC) #1
wtc
Henrik: could you please test this change and see if it fixes your build error? ...
6 years, 4 months ago (2014-08-21 21:44:00 UTC) #2
kjellander_chromium
On 2014/08/21 21:44:00, wtc wrote: > Henrik: could you please test this change and see ...
6 years, 4 months ago (2014-08-22 10:31:47 UTC) #3
tkchin
On 2014/08/22 10:31:47, kjellander wrote: > On 2014/08/21 21:44:00, wtc wrote: > > Henrik: could ...
6 years, 4 months ago (2014-08-22 17:26:23 UTC) #4
wtc
Thank you for testing the CL and suggesting a fix. Please review patch set 2. ...
6 years, 4 months ago (2014-08-22 18:49:18 UTC) #5
kjellander_chromium
lgtm, thanks for fixing this. Please go ahead and land this asap, if you have ...
6 years, 4 months ago (2014-08-24 13:49:00 UTC) #6
wtc
The CQ bit was checked by wtc@chromium.org
6 years, 4 months ago (2014-08-24 15:22:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/493213002/20001
6 years, 4 months ago (2014-08-24 15:23:09 UTC) #8
commit-bot: I haz the power
6 years, 4 months ago (2014-08-24 15:23:48 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (20001) as 291588

Powered by Google App Engine
This is Rietveld 408576698