Issue 493203005: Add ScopedForbidReturn and its test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 493203005: Add ScopedForbidReturn and its test (Closed)

Created:
6 years, 3 months ago by Mark Mentovai

Modified:
6 years, 3 months ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

Add ScopedForbidReturn and its test. Use ScopedForbidReturn in ProcessReader::InitializeThreads(). TEST=util_test ScopedForbidReturn*.* R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/0cc86a24f947

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+147 lines, -0 lines)			Patch
M	util/mac/process_reader.cc	View		3 chunks	+4 lines, -0 lines	0 comments	Download
A	util/misc/scoped_forbid_return.h	View	1 2	1 chunk	+54 lines, -0 lines	0 comments	Download
A	util/misc/scoped_forbid_return.cc	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download
A	util/misc/scoped_forbid_return_test.cc	View	1 2	1 chunk	+59 lines, -0 lines	0 comments	Download
M	util/util.gyp	View		2 chunks	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Mark Mentovai

mark@chromium.org changed reviewers: + rsesek@chromium.org

6 years, 3 months ago (2014-08-26 17:02:50 UTC) #1

Mark Mentovai

I was refactoring MachMultiprocess to have a non-Mach base and realized that the scoper in ...

6 years, 3 months ago (2014-08-26 17:02:50 UTC) #2

Mark Mentovai

6 years, 3 months ago (2014-08-26 20:50:20 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as 0cc86a24f947 (presubmit successful).