chrome/browser/resources/hotword/manifest.json - Issue 493203004: Add a StateManager for managing hotwording state based on various factors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/hotword/manifest.json

Issue 493203004: Add a StateManager for managing hotwording state based on various factors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@hotword-nacl-manager

Patch Set: Address review comments. Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/hotword/manager.js ('K') | « chrome/browser/resources/hotword/manager.js ('k') | chrome/browser/resources/hotword/state_manager.js » ('j') | chrome/browser/resources/hotword/state_manager.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/hotword/manifest.json

diff --git a/chrome/browser/resources/hotword/manifest.json b/chrome/browser/resources/hotword/manifest.json

index 4fb5b11ca95ef386e082af2f9ed221674527def1..4d75c2ace1f5c9b50fed9cf7a0c448d48f5ca6ae 100644

--- a/chrome/browser/resources/hotword/manifest.json

+++ b/chrome/browser/resources/hotword/manifest.json

@@ -3,7 +3,7 @@

"key": "MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDbHXRPiq2De9EJ+4pvNN6uE/D2avxrqyLSpA/Hq3II+btkPl1gboY3oUPTfevpVOFa90Y1c1b3/W682dXqybT0klIvFLKhdQx0LiVqSUQyIaDrwOCSo/ZcukbEwDRojegWymCjHvX6WZk4kKZzTJYzY1vrp0TWKLhttEMN9KFmowIDAQAB",

"name": "Hotword triggering",

- "version": "0.0.1.0",

+ "version": "0.0.1.1",

"manifest_version": 2,

"background": {

@@ -13,6 +13,7 @@

"chrome://resources/js/cr/event_target.js",

"constants.js",

"nacl_manager.js",

+ "state_manager.js",

"manager.js"

"persistent": false

@@ -22,7 +23,9 @@

"*://*.google.com/*",

"chrome://newtab/",

"chrome://resources/",

+ "audioCapture",

"hotwordPrivate",

+ "management",

"tabs"

@@ -42,5 +45,6 @@

}

+ "content_security_policy": "object-src 'none'; script-src chrome://resources 'self'",

"minimum_chrome_version": "38"

}