Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Side by Side Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 493203003: Disable WorkerDevToolsSanityTest.InspectSharedWorker everywhere. It also fails on CrOS. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/bind.h" 5 #include "base/bind.h"
6 #include "base/cancelable_callback.h" 6 #include "base/cancelable_callback.h"
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "base/path_service.h" 10 #include "base/path_service.h"
(...skipping 830 matching lines...) Expand 10 before | Expand all | Expand 10 after
841 ASSERT_TRUE( 841 ASSERT_TRUE(
842 content::ExecuteScriptAndExtractString( 842 content::ExecuteScriptAndExtractString(
843 main_web_contents()->GetRenderViewHost(), 843 main_web_contents()->GetRenderViewHost(),
844 "window.domAutomationController.send(" 844 "window.domAutomationController.send("
845 " '' + (window.uiTests && (typeof uiTests.runTest)));", 845 " '' + (window.uiTests && (typeof uiTests.runTest)));",
846 &result)); 846 &result));
847 ASSERT_EQ("function", result) << "DevTools front-end is broken."; 847 ASSERT_EQ("function", result) << "DevTools front-end is broken.";
848 CloseDevToolsWindow(); 848 CloseDevToolsWindow();
849 } 849 }
850 850
851 #if defined(OS_MACOSX) 851 // Flakily fails: http://crbug.com/403007 http://crbug.com/89845
852 #define MAYBE_InspectSharedWorker DISABLED_InspectSharedWorker 852 IN_PROC_BROWSER_TEST_F(WorkerDevToolsSanityTest, DISABLED_InspectSharedWorker) {
853 #elif defined(OS_WIN)
854 // Disabled on Windows due to flakiness. http://crbug.com/403007
855 #define MAYBE_InspectSharedWorker DISABLED_InspectSharedWorker
856 #else
857 #define MAYBE_InspectSharedWorker InspectSharedWorker
858 #endif
859 // Flakily fails with 25s timeout: http://crbug.com/89845
860 IN_PROC_BROWSER_TEST_F(WorkerDevToolsSanityTest, MAYBE_InspectSharedWorker) {
861 #if defined(OS_WIN) && defined(USE_ASH) 853 #if defined(OS_WIN) && defined(USE_ASH)
862 // Disable this test in Metro+Ash for now (http://crbug.com/262796). 854 // Disable this test in Metro+Ash for now (http://crbug.com/262796).
863 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests)) 855 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
864 return; 856 return;
865 #endif 857 #endif
866 858
867 RunTest("testSharedWorker", kSharedWorkerTestPage); 859 RunTest("testSharedWorker", kSharedWorkerTestPage);
868 } 860 }
869 861
870 // http://crbug.com/100538 862 // http://crbug.com/100538
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
917 909
918 IN_PROC_BROWSER_TEST_F(RemoteDebuggingTest, RemoteDebugger) { 910 IN_PROC_BROWSER_TEST_F(RemoteDebuggingTest, RemoteDebugger) {
919 #if defined(OS_WIN) && defined(USE_ASH) 911 #if defined(OS_WIN) && defined(USE_ASH)
920 // Disable this test in Metro+Ash for now (http://crbug.com/262796). 912 // Disable this test in Metro+Ash for now (http://crbug.com/262796).
921 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests)) 913 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kAshBrowserTests))
922 return; 914 return;
923 #endif 915 #endif
924 916
925 ASSERT_TRUE(RunExtensionTest("target_list")) << message_; 917 ASSERT_TRUE(RunExtensionTest("target_list")) << message_;
926 } 918 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698