Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1759)

Issue 493173003: Fix issue with numeric property names (Closed)

Created:
6 years, 4 months ago by arv (Not doing code reviews)
Modified:
6 years, 4 months ago
Reviewers:
marja
CC:
v8-dev, wingo
Project:
v8
Visibility:
Public.

Description

Fix issue with numeric property names We were not correctly treating 1.0 as 1, nor 1.20 as 1.2 in accessors. BUG=v8:3507 LOG=Y R=marja@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23321

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -4 lines) Patch
M src/parser.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/parser.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M src/preparser.h View 2 chunks +2 lines, -4 lines 0 comments Download
M src/preparser.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M test/mjsunit/object-literal.js View 1 chunk +70 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
arv (Not doing code reviews)
6 years, 4 months ago (2014-08-21 18:33:26 UTC) #1
marja
lgtm
6 years, 4 months ago (2014-08-22 08:08:30 UTC) #2
arv (Not doing code reviews)
6 years, 4 months ago (2014-08-22 14:40:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as 23321 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698