Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(569)

Unified Diff: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm

Issue 493143004: mac: Major fullscreen refactor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to rsesek comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
index 5e173d9f660309fb66f1f7e6b10de8425ea7366c..84d2b6c9465c1d4b0f5e4881c61638091ffb9d81 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_unittest.mm
@@ -831,15 +831,15 @@ void WaitForFullScreenTransition() {
// http://crbug.com/53586
TEST_F(BrowserWindowFullScreenControllerTest, DISABLED_TestFullscreen) {
[controller_ showWindow:nil];
- EXPECT_FALSE([controller_ isFullscreen]);
+ EXPECT_FALSE([controller_ isInOrEnteringAnyFullscreenMode]);
- [controller_ enterFullscreen];
+ [controller_ enterFullscreenWithChrome];
WaitForFullScreenTransition();
- EXPECT_TRUE([controller_ isFullscreen]);
+ EXPECT_TRUE([controller_ isInOrEnteringAnyFullscreenMode]);
- [controller_ exitFullscreen];
+ [controller_ exitGenericFullscreen];
WaitForFullScreenTransition();
- EXPECT_FALSE([controller_ isFullscreen]);
+ EXPECT_FALSE([controller_ isInOrEnteringAnyFullscreenMode]);
}
// If this test fails, it is usually a sign that the bots have some sort of
@@ -850,12 +850,12 @@ TEST_F(BrowserWindowFullScreenControllerTest, DISABLED_TestFullscreen) {
TEST_F(BrowserWindowFullScreenControllerTest, DISABLED_TestActivate) {
[controller_ showWindow:nil];
- EXPECT_FALSE([controller_ isFullscreen]);
+ EXPECT_FALSE([controller_ isInOrEnteringAnyFullscreenMode]);
[controller_ activate];
EXPECT_TRUE(IsFrontWindow([controller_ window]));
- [controller_ enterFullscreen];
+ [controller_ enterFullscreenWithChrome];
WaitForFullScreenTransition();
[controller_ activate];
@@ -864,7 +864,7 @@ TEST_F(BrowserWindowFullScreenControllerTest, DISABLED_TestActivate) {
EXPECT_TRUE(IsFrontWindow([controller_ createFullscreenWindow]));
// We have to cleanup after ourselves by unfullscreening.
- [controller_ exitFullscreen];
+ [controller_ exitGenericFullscreen];
WaitForFullScreenTransition();
}

Powered by Google App Engine
This is Rietveld 408576698