mac: Major fullscreen refactor.

chrome/browser/ui/cocoa/browser_window_controller_private.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_PRIVATE_H_
 #define CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_PRIVATE_H_
 
 #import "chrome/browser/ui/cocoa/browser_window_controller.h"
 
 // Private methods for the |BrowserWindowController|. This category should
@@ skipping 94 matching lines @@
 // does not position views; callers must also call |-layoutSubviews:|.
 - (void)moveViewsForImmersiveFullscreen:(BOOL)fullscreen
                           regularWindow:(NSWindow*)regularWindow
                        fullscreenWindow:(NSWindow*)fullscreenWindow;
 
 // Called when a permission bubble closes, and informs the presentation
 // controller that the dropdown can be hidden.  (The dropdown should never be
 // hidden while a permissions bubble is visible.)
 - (void)permissionBubbleWindowWillClose:(NSNotification*)notification;
 
-// Sets presentation mode, creating the PresentationModeController if needed and
-// forcing a relayout.  If |forceDropdown| is YES, this method will always
-// initially show the floating bar when entering presentation mode, even if the
-// floating bar does not have focus.  This method is safe to call on all OS
-// versions.
-- (void)setPresentationModeInternal:(BOOL)presentationMode
-                      forceDropdown:(BOOL)forceDropdown;
-
 // Enter or exit fullscreen without using Cocoa's System Fullscreen API.  These
 // methods are internal implementations of |-setFullscreen:|.
 - (void)enterImmersiveFullscreen;
 - (void)exitImmersiveFullscreen;
 
 // Register or deregister for content view resize notifications.  These
 // notifications are used while transitioning into fullscreen mode using Cocoa's
 // System Fullscreen API.
 - (void)registerForContentViewResizeNotifications;
 - (void)deregisterForContentViewResizeNotifications;
 
-// Adjust the UI when entering or leaving presentation mode.  This method is
-// safe to call on all OS versions.
-- (void)adjustUIForPresentationMode:(BOOL)fullscreen;
-
 // Allows/prevents bar visibility locks and releases from updating the visual
 // state. Enabling makes changes instantaneously; disabling cancels any
 // timers/animation.
 - (void)enableBarVisibilityUpdates;
 - (void)disableBarVisibilityUpdates;
 
 // If there are no visibility locks and bar visibity updates are enabled, hides
 // the bar with |animation| and |delay|.  Otherwise, does nothing.
 - (void)hideOverlayIfPossibleWithAnimation:(BOOL)animation delay:(BOOL)delay;
 
 // The opacity for the toolbar divider; 0 means that it shouldn't be shown.
 - (CGFloat)toolbarDividerOpacity;
 
 // Ensures the z-order of subviews is correct.
 - (void)updateSubviewZOrder:(BOOL)inPresentationMode;
 
 // Update visibility of the infobar tip, depending on the state of the window.
 - (void)updateInfoBarTipVisibility;
 
+// Returns whether to show the dropdown.
+- (BOOL)commonAppKitFullscreenSetup;

[Robert Sesek, 2014/08/27 22:04:30]

This method is not named appropriately for returning a BOOL.

[erikchen, 2014/08/28 00:50:28]

I moved a small amount of code around to give this method a concise name.

+
+// Allows the omnibox to slide. Also prepares UI for several fullscreen modes.
+// This method gets called when entering AppKit fullscren, or when entering
+// Immersive fullscreen. Expects fullscreenStyle_ to be set.
+- (void)adjustUIForSlidingFullscreenStyle:(fullscreen_mac::SlidingStyle)style;
+
+// This method gets called when exiting AppKit fullscreen, or when exiting
+// Immersive fullscreen. It performs some common UI changes, and stops the
+// omnibox from sliding.
+- (void)adjustUIForExitingFullscreenAndStopOmniboxSliding;
+
+// Toggles the AppKit Fullscreen API. By default, doing so enters System

[Robert Sesek, 2014/08/27 22:04:30]

Why reference system fullscreen if that's a deprecated term?

[erikchen, 2014/08/28 00:50:28]

Oops. That was a mistake.

+// Fullscreen.
+- (void)enterAppKitFullscreen;
+- (void)exitAppKitFullscreen;
+
 @end  // @interface BrowserWindowController(Private)
 
 #endif  // CHROME_BROWSER_UI_COCOA_BROWSER_WINDOW_CONTROLLER_PRIVATE_H_