[Win, Profiles] Changing your default avatar should not change your default name

[Win, Profiles] Changing your default avatar should not change your default name

Two things going wrong:
- the Windows new avatar button wasn't listening to avatar changes, so
its display would be out of sync with the avatar bubble
- when saving the avatar photo, this was also considered a name save
(even though the name wouldn't change), which made the default name an
explicit user decision (which it wasn't)

BUG=405750
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291258

[noms (inactive), 2014-08-21 15:41:08]

Making Profiles work correctly, one CL at a time :)

+ Scott: c/b/ui/views/*
+ Roger: c/b/profiles/*

Thanks!

[sky, 2014-08-21 16:55:12]

LGTM

[Roger Tawa OOO till Jul 10th, 2014-08-21 18:32:32]

lgtm

https://codereview.chromium.org/493113002/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profiles_state.cc (right):

https://codereview.chromium.org/493113002/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profiles_state.cc:100: return;
Should this be a DCHECK?

[noms (inactive), 2014-08-21 18:36:18]

https://codereview.chromium.org/493113002/diff/1/chrome/browser/profiles/prof...
File chrome/browser/profiles/profiles_state.cc (right):

https://codereview.chromium.org/493113002/diff/1/chrome/browser/profiles/prof...
chrome/browser/profiles/profiles_state.cc:100: return;
Ugh, everything is peppered with this kind of check, unfortunately. It wouldn't
help if it's a DCHECK, because at runtime you could get into a situations where
you have a profile but the info cache doesn't know about it. I don't know how
you'd get into this situation, but this is why we do it :(

On 2014/08/21 18:32:31, Roger Tawa wrote:
> Should this be a DCHECK?

[noms (inactive), 2014-08-21 19:44:00]

The CQ bit was checked by noms@chromium.org

[commit-bot: I haz the power, 2014-08-21 19:45:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/noms@chromium.org/493113002/1

[commit-bot: I haz the power, 2014-08-22 00:07:57]

Committed patchset #1 (1) as 291258