Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7760)

Unified Diff: chrome/test/data/webrtc/manual/peerconnection_manual.js

Issue 493073002: warning_ and error_ functions are now wired to onunmute and onmute events (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webrtc/manual/peerconnection_manual.js
diff --git a/chrome/test/data/webrtc/manual/peerconnection_manual.js b/chrome/test/data/webrtc/manual/peerconnection_manual.js
index 40ac84a4205235244caef9c7159c1aac27066bd7..a631f05a546aaf625ce8562a8a9552a2b203e156 100644
--- a/chrome/test/data/webrtc/manual/peerconnection_manual.js
+++ b/chrome/test/data/webrtc/manual/peerconnection_manual.js
@@ -916,6 +916,12 @@ function success_(method) {
}
/** @private */
+function warning_(message) {
mcasas 2014/08/21 10:53:17 It seems that there are: - function print_(message
+ $('debug').innerHTML += '<span style="color:orange;">' + message +
+ '</span><br>';
+}
+
+/** @private */
function failure_(method, error) {
error_(method + '() failed: ' + JSON.stringify(error));
}
@@ -1007,13 +1013,13 @@ function getUserMediaOkCallback_(stream) {
};
// Print information on track going to mute or back from it.
- // TODO(mcasas): add a warning_() function and move the following print_()
- // notifications to error_() and warning_(), respectively.
stream.getVideoTracks()[0].onmute = function() {
- print_(global.localStream + ' track onmute event has fired');
+ error_(global.localStream + ' MediaStreamTrack.onmute event has fired, ' +
+ 'no frames to the track.');
};
stream.getVideoTracks()[0].onunmute = function() {
- print_(global.localStream + ' track onunmute event has fired');
+ warning_(global.localStream + ' MediaStreamTrack.onunmute event has ' +
+ 'fired.');
};
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698