warning_ and error_ functions are now wired to onunmute and onmute events

warning_ and error_ functions are now wired to onunmute and onmute events

Added warning_ function that highlights messages in orange in the debug
message panel.

MediaStreamTrack.onmute and MediaStreamTrack.onunmute are now
highlighted in red as an error and in orange as a warning.

BUG=None
TEST=Manually triggered the events directly.
NOTRY=TRUE

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291386

[mcasas, 2014-08-21 10:53:17]

https://codereview.chromium.org/493073002/diff/20001/chrome/test/data/webrtc/...
File chrome/test/data/webrtc/manual/peerconnection_manual.js (right):

https://codereview.chromium.org/493073002/diff/20001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/manual/peerconnection_manual.js:919: function
warning_(message) {
It seems that there are:
- function print_(message)
- function debug_(message)
- function error_(message)
  (these three around l.1143
- function warning_(message)
- function failure_(method, error)

and they are all very similar. Could you bring them together and consolidate the
common parts?

[jansson, 2014-08-21 12:13:13]

Created a general print_handler function and cleared up some of the redundant
code. More cleanup is needed, there are lots of remnants of the automation error
messages etc.

[mcasas, 2014-08-21 12:28:36]

Good cleanup! Still a couple of minors, but getting there.

Note: you can remove uploaded intermediate patch sets via
"Delete" link on the Patch Set line, rightmost. Just keep those
with reviews/comments.

https://codereview.chromium.org/493073002/diff/90001/chrome/test/data/webrtc/...
File chrome/test/data/webrtc/manual/peerconnection_manual.js (right):

https://codereview.chromium.org/493073002/diff/90001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/manual/peerconnection_manual.js:1122: * @param {!string}
message Text to print.
What's the exclamation mark doing? Other methods don't have it.

https://codereview.chromium.org/493073002/diff/90001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/manual/peerconnection_manual.js:1159: if ( color ==
'green' )
Remove space before |color|.

https://codereview.chromium.org/493073002/diff/90001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/manual/peerconnection_manual.js:1164: if (color == 'red'
)
I'd move this to first thing in print_handler_()

[jansson, 2014-08-21 16:26:21]

Thanks for the tip regarding removing patch sets, had not noticed that option.

https://codereview.chromium.org/493073002/diff/90001/chrome/test/data/webrtc/...
File chrome/test/data/webrtc/manual/peerconnection_manual.js (right):

https://codereview.chromium.org/493073002/diff/90001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/manual/peerconnection_manual.js:1122: * @param {!string}
message Text to print.
On 2014/08/21 12:28:36, mcasas wrote:
> What's the exclamation mark doing? Other methods don't have it.
It indicates that the there has to a non-nullable type passed as a parameter. I
think its mostly used for objects, but Google JS styleguide follows JSDoc,
http://usejsdoc.org/tags-type.html.  Example in there is for the number type,
not sure if it's really applicable for strings.

https://codereview.chromium.org/493073002/diff/90001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/manual/peerconnection_manual.js:1159: if ( color ==
'green' )
On 2014/08/21 12:28:36, mcasas wrote:
> Remove space before |color|.

Done.

https://codereview.chromium.org/493073002/diff/90001/chrome/test/data/webrtc/...
chrome/test/data/webrtc/manual/peerconnection_manual.js:1164: if (color == 'red'
)
On 2014/08/21 12:28:36, mcasas wrote:
> I'd move this to first thing in print_handler_()

Done.

[mcasas, 2014-08-22 09:54:38]

LGTM.

So now we have print_(), success_(), error_() and warning_(), right?

[jansson, 2014-08-22 11:12:43]

On 2014/08/22 09:54:38, mcasas wrote:
> LGTM.
> 
> So now we have print_(), success_(), error_() and warning_(), right?

Yes, that's correct.

[jansson, 2014-08-22 11:12:47]

The CQ bit was checked by jansson@chromium.org

[commit-bot: I haz the power, 2014-08-22 11:13:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jansson@chromium.org/493073002/110001

[commit-bot: I haz the power, 2014-08-22 11:14:21]

Committed patchset #4 (110001) as 291386