[SyncFS] Add browser_tests to test authentication state of SyncFS

[SyncFS] Add browser_tests to test authentication state of SyncFS

BUG=402356
TEST=browser_tests --gtest_filter=SyncFileSystemTest.AuthorizationTest

Committed: https://crrev.com/b6f10aa31c8391dc16013731aeda3f8484aa0014
Cr-Commit-Position: refs/heads/master@{#296359}

[tzik, 2014-09-04 09:46:13]

tzik@chromium.org changed reviewers:
+ peria@chromium.org

[tzik, 2014-09-04 09:46:14]

PTL

[peria, 2014-09-05 04:55:35]

over all, looks good.

Would you fill BUG and TEST lines?

https://codereview.chromium.org/493043002/diff/80001/chrome/browser/extension...
File
chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc
(right):

https://codereview.chromium.org/493043002/diff/80001/chrome/browser/extension...
chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc:54:
public ChangeObserver {
(optional) Would you use the original name
"drive::FakeDriveService::ChangeObserver" here?

https://codereview.chromium.org/493043002/diff/80001/chrome/browser/extension...
chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc:94:
scoped_ptr<FakeDriveServiceFactory> drive_service_factory(
Can we rewrite the type to
scoped_ptr<drive_backend::SyncEngine::DriveServiceFactory>
and #111 to |drive_service_factory.Pass()| ?

[tzik, 2014-09-08 07:00:37]

https://codereview.chromium.org/493043002/diff/80001/chrome/browser/extension...
File
chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc
(right):

https://codereview.chromium.org/493043002/diff/80001/chrome/browser/extension...
chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc:54:
public ChangeObserver {
On 2014/09/05 04:55:35, peria wrote:
> (optional) Would you use the original name
> "drive::FakeDriveService::ChangeObserver" here?

Done.

https://codereview.chromium.org/493043002/diff/80001/chrome/browser/extension...
chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc:94:
scoped_ptr<FakeDriveServiceFactory> drive_service_factory(
On 2014/09/05 04:55:35, peria wrote:
> Can we rewrite the type to
> scoped_ptr<drive_backend::SyncEngine::DriveServiceFactory>
> and #111 to |drive_service_factory.Pass()| ?

Done.

[peria, 2014-09-08 07:05:04]

lgtm

with a nit

https://codereview.chromium.org/493043002/diff/120001/chrome/browser/extensio...
File
chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc
(right):

https://codereview.chromium.org/493043002/diff/120001/chrome/browser/extensio...
chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc:94:
drive_service_factory(
nit: connect with the next line, if possible

[tzik, 2014-09-08 07:30:22]

https://codereview.chromium.org/493043002/diff/120001/chrome/browser/extensio...
File
chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc
(right):

https://codereview.chromium.org/493043002/diff/120001/chrome/browser/extensio...
chrome/browser/extensions/api/sync_file_system/sync_file_system_browsertest.cc:94:
drive_service_factory(
On 2014/09/08 07:05:04, peria wrote:
> nit: connect with the next line, if possible

Done.

[tzik, 2014-09-11 07:34:20]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-09-11 07:35:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/493043002/200001

[commit-bot: I haz the power, 2014-09-11 08:01:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-11 08:01:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tzik, 2014-09-12 04:36:39]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-09-12 04:37:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/493043002/200001

[commit-bot: I haz the power, 2014-09-12 04:51:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-12 04:51:53]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tzik, 2014-09-24 06:17:13]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2014-09-24 06:18:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/493043002/220001

[commit-bot: I haz the power, 2014-09-24 07:13:16]

Committed patchset #12 (id:220001) as 68c1a9425c2964ccc6e6b39b6b3e3995051eed4f

[commit-bot: I haz the power, 2014-09-24 07:13:56]

Patchset 12 (id:??) landed as
https://crrev.com/b6f10aa31c8391dc16013731aeda3f8484aa0014
Cr-Commit-Position: refs/heads/master@{#296359}