Issue 49303008: Don't use select() in SyncSocket when handle > FD_SETSIZE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 49303008: Don't use select() in SyncSocket when handle > FD_SETSIZE. (Closed)

Created:
7 years, 1 month ago by DaleCurtis

Modified:
7 years, 1 month ago

Reviewers:
awong

CC:
chromium-reviews, erikwright+watch_chromium.org, jar (doing other things)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't use select() in SyncSocket when handle > FD_SETSIZE. BUG=314364 TEST=audio playback still works, just glitches in 48->44 R=ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232845

Patch Set 2 : Clarify. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	base/sync_socket_posix.cc	View	1	1 chunk	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

awong

LGTM w/ nit https://codereview.chromium.org/49303008/diff/1/base/sync_socket_posix.cc File base/sync_socket_posix.cc (right): https://codereview.chromium.org/49303008/diff/1/base/sync_socket_posix.cc#newcode132 base/sync_socket_posix.cc:132: // Receive() now and return an ...

7 years, 1 month ago (2013-11-04 23:25:23 UTC) #2

DaleCurtis

Thanks! https://codereview.chromium.org/49303008/diff/1/base/sync_socket_posix.cc File base/sync_socket_posix.cc (right): https://codereview.chromium.org/49303008/diff/1/base/sync_socket_posix.cc#newcode132 base/sync_socket_posix.cc:132: // Receive() now and return an error if ...

7 years, 1 month ago (2013-11-04 23:32:25 UTC) #3

DaleCurtis

7 years, 1 month ago (2013-11-05 00:14:50 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r232845 (presubmit successful).

Expand Messages | Collapse Messages

Issue 49303008: Don't use select() in SyncSocket when handle > FD_SETSIZE. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Clarify. #

Messages