Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 49303007: Moves responsibility of invoking OnNativeWidgetCreated to DesktopRootWindowHost (Closed)

Created:
7 years, 1 month ago by sky
Modified:
7 years, 1 month ago
CC:
chromium-reviews, tfarina, ben+views_chromium.org
Visibility:
Public.

Description

Moves responsibility of invoking OnNativeWidgetCreated to DesktopRootWindowHost I had centralized this in DesktopNativeWidgetAura, but it needs to be in the DesktopRootWindowHost implementations as it may be invoked during construction so that state can be set up. Otherwise we may crash if during init state isn't set up. I added test for coverage. BUG=313780 TEST=covered by unit test R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233012

Patch Set 1 #

Patch Set 2 : comments #

Patch Set 3 : merge 2 trunk #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -3 lines) Patch
M ui/views/views.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_win.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A ui/views/widget/desktop_aura/desktop_root_window_host_win_unittest.cc View 1 1 chunk +55 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_root_window_host_x11.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sky
7 years, 1 month ago (2013-11-04 15:40:54 UTC) #1
Ben Goodger (Google)
lgtm
7 years, 1 month ago (2013-11-04 21:27:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/49303007/190001
7 years, 1 month ago (2013-11-04 21:36:13 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184482
7 years, 1 month ago (2013-11-05 01:34:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/49303007/190001
7 years, 1 month ago (2013-11-05 04:16:30 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=184858
7 years, 1 month ago (2013-11-05 06:58:29 UTC) #6
sky
7 years, 1 month ago (2013-11-05 17:10:28 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 manually as r233012 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698