Parameterize the PrefService that AutofillDownloadManager uses.

components/autofill/core/browser/autofill_download.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_DOWNLOAD_H_
 #define COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_DOWNLOAD_H_
 
 #include <stddef.h>
 #include <list>
 #include <map>
 #include <string>
 #include <utility>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/gtest_prod_util.h"
 #include "base/time/time.h"
 #include "components/autofill/core/browser/autofill_type.h"
 #include "net/url_request/url_fetcher_delegate.h"
 
+class PrefService;
+
 namespace content {
 class BrowserContext;
 }  // namespace content
 
 namespace net {
 class URLFetcher;
 }  // namespace net
 
 namespace autofill {
 
@@ skipping 24 matching lines @@
     // |request_type| - type of request that failed.
     // |http_error| - HTTP error code.
     virtual void OnServerRequestError(const std::string& form_signature,
                                       AutofillRequestType request_type,
                                       int http_error) {}
 
    protected:
     virtual ~Observer() {}
   };
 
+  // |context| and |pref_service| must outlive this instance.
   // |observer| - observer to notify on successful completion or error.
   AutofillDownloadManager(content::BrowserContext* context,
+                          PrefService* pref_service,
                           Observer* observer);
   virtual ~AutofillDownloadManager();
 
   // Starts a query request to Autofill servers. The observer is called with the
   // list of the fields of all requested forms.
   // |forms| - array of forms aggregated in this request.
   bool StartQueryRequest(const std::vector<FormStructure*>& forms,
                          const AutofillMetrics& metric_logger);
 
   // Starts an upload request for the given |form|, unless throttled by the
@@ skipping 52 matching lines @@
   // GetNegativeUploadRate() for non-matched.
   double GetPositiveUploadRate() const;
   double GetNegativeUploadRate() const;
   void SetPositiveUploadRate(double rate);
   void SetNegativeUploadRate(double rate);
 
   // The pointer value is const, so this can only be set in the
   // constructor.  Must not be null.
   content::BrowserContext* const browser_context_;  // WEAK
 
+  // The pointer value is const, so this can only be set in the
+  // constructor.  Must not be null, and must outlive this instance.

[Ilya Sherman, 2013/11/05 00:17:04]

nit: No need to document what "const" means -- that should be clear from the
code to anyone sufficiently familiar with C++, and easy to research to anyone
who doesn't quite remember what "const" means in this context.  Please instead
document the role or purpose of this data member.  (I see that this was probably
copied from the above and below comments, but IMO those should be shortened as
well; this really is a language detail that ought to be safe to assume as common
knowledge.)

[blundell, 2013/11/05 15:26:54]

Done.

+  PrefService* const pref_service_;  // WEAK
+
   // The observer to notify when server predictions are successfully received.
   // The pointer value is const, so this can only be set in the constructor.
   // Must not be null.
   AutofillDownloadManager::Observer* const observer_;  // WEAK
 
   // For each requested form for both query and upload we create a separate
   // request and save its info. As url fetcher is identified by its address
   // we use a map between fetchers and info.
   std::map<net::URLFetcher*, FormRequestData> url_fetchers_;
 
@@ skipping 12 matching lines @@
   double positive_upload_rate_;
   double negative_upload_rate_;
 
   // Needed for unit-test.
   int fetcher_id_for_unittest_;
 };
 
 }  // namespace autofill
 
 #endif  // COMPONENTS_AUTOFILL_CORE_BROWSER_AUTOFILL_DOWNLOAD_H_