Merge apps/pref* to extensions/browser/pref*

Merge apps/pref* to extensions/browser/pref*

The pref's exclusive user AppWindow will move to extensions/browser

Merge apps/pref_names.{cc,h} to extensions/browser/pref_names.{cc,h}
Merge apps/prefs.{cc,h} to extensions/browser/extension_prefs.cc

BUG=403726
Committed: https://chromium.googlesource.com/chromium/src/+/3da4417c5baa6b8fe0be9aa012f0fd3294d9dbc7

Committed: https://crrev.com/2d1cf16698ef2680ea50014b015fecf6db32e730
Cr-Commit-Position: refs/heads/master@{#291655}

[hashimoto, 2014-08-21 04:49:16]

https://codereview.chromium.org/493003002/diff/1/extensions/browser/pref_name...
File extensions/browser/pref_names.cc (right):

https://codereview.chromium.org/493003002/diff/1/extensions/browser/pref_name...
extensions/browser/pref_names.cc:33: const char kAppFullscreenAllowed[] =
"apps.fullscreen.allowed";
Is it OK to leave this "apps.*" unchanged?
Or should this be changed to "extensions.fullscreen.allowed"(possibly with pref
migration code)?

[benwells, 2014-08-22 00:58:50]

lgtm

https://codereview.chromium.org/493003002/diff/1/extensions/browser/pref_name...
File extensions/browser/pref_names.cc (right):

https://codereview.chromium.org/493003002/diff/1/extensions/browser/pref_name...
extensions/browser/pref_names.cc:33: const char kAppFullscreenAllowed[] =
"apps.fullscreen.allowed";
On 2014/08/21 04:49:16, hashimoto wrote:
> Is it OK to leave this "apps.*" unchanged?
> Or should this be changed to "extensions.fullscreen.allowed"(possibly with
pref
> migration code)?

It is fine as is.

[hashimoto, 2014-08-22 02:24:34]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-08-22 02:24:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/493003002/1

[commit-bot: I haz the power, 2014-08-22 03:19:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[commit-bot: I haz the power, 2014-08-22 03:21:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-22 03:21:12]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[hashimoto, 2014-08-22 05:24:04]

bauerb@: Please review this change as an owner of
chrome/browser/prefs/browser_prefs.cc.

bartfab@: Please reivew this change as an owner of
chrome/browser/policy/configuration_policy_handler_list_factory.cc.

[Bernhard Bauer, 2014-08-22 18:08:04]

prefs/ LGTM (feel free to TBR trivial changes like this if the overall CL has
been LGTM'd).

[hashimoto, 2014-08-25 07:25:11]

TBRing bartfab@chromium.org for include fix in
configuration_policy_handler_list_factory.cc.

[hashimoto, 2014-08-25 07:25:14]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-08-25 07:26:05]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/493003002/1

[commit-bot: I haz the power, 2014-08-25 08:19:23]

Committed patchset #1 (1) as 3da4417c5baa6b8fe0be9aa012f0fd3294d9dbc7

[bartfab (slow), 2014-08-25 08:44:17]

configuration_policy_handler_list_factory.cc lgtm

[Michael Achenbach, 2014-08-25 08:45:27]

A revert of this CL (patchset #1) has been created in
https://codereview.chromium.org/499253002/ by machenbach@chromium.org.

The reason for reverting is: Breaks GN:

http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/10608.

[hashimoto, 2014-08-25 08:55:11]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2014-08-25 08:55:46]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hashimoto@chromium.org/493003002/20001

[commit-bot: I haz the power, 2014-08-25 11:08:36]

Committed patchset #2 (20001) as 374e77b4c453ec23c72d1181b24dfe478a36f8da

[commit-bot: I haz the power, 2014-09-10 02:33:22]

Patchset 2 (id:??) landed as
https://crrev.com/77b343e018d1ed88bc9ce96fc9a9055c2e1c5cde
Cr-Commit-Position: refs/heads/master@{#291650}

[commit-bot: I haz the power, 2014-09-10 02:33:33]

Patchset 2 (id:??) landed as
https://crrev.com/2d1cf16698ef2680ea50014b015fecf6db32e730
Cr-Commit-Position: refs/heads/master@{#291655}