Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Issue 493003002: Merge apps/pref* to extensions/browser/pref* (Closed)

Created:
6 years, 4 months ago by hashimoto
Modified:
6 years, 3 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Project:
chromium
Visibility:
Public.

Description

Merge apps/pref* to extensions/browser/pref* The pref's exclusive user AppWindow will move to extensions/browser Merge apps/pref_names.{cc,h} to extensions/browser/pref_names.{cc,h} Merge apps/prefs.{cc,h} to extensions/browser/extension_prefs.cc BUG=403726 Committed: https://chromium.googlesource.com/chromium/src/+/3da4417c5baa6b8fe0be9aa012f0fd3294d9dbc7 Committed: https://crrev.com/2d1cf16698ef2680ea50014b015fecf6db32e730 Cr-Commit-Position: refs/heads/master@{#291655}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix GN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -96 lines) Patch
M apps/BUILD.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
M apps/app_window.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M apps/apps.gypi View 1 1 chunk +0 lines, -4 lines 0 comments Download
D apps/pref_names.h View 1 chunk +0 lines, -18 lines 0 comments Download
D apps/pref_names.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D apps/prefs.h View 1 chunk +0 lines, -21 lines 0 comments Download
D apps/prefs.cc View 1 chunk +0 lines, -21 lines 0 comments Download
M chrome/browser/apps/app_launch_for_metro_restart_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/policy/configuration_policy_handler_list_factory.cc View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/prefs/browser_prefs.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/app_list_service_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/extension_prefs.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M extensions/browser/pref_names.h View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/pref_names.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
hashimoto
https://codereview.chromium.org/493003002/diff/1/extensions/browser/pref_names.cc File extensions/browser/pref_names.cc (right): https://codereview.chromium.org/493003002/diff/1/extensions/browser/pref_names.cc#newcode33 extensions/browser/pref_names.cc:33: const char kAppFullscreenAllowed[] = "apps.fullscreen.allowed"; Is it OK to ...
6 years, 4 months ago (2014-08-21 04:49:16 UTC) #1
benwells
lgtm https://codereview.chromium.org/493003002/diff/1/extensions/browser/pref_names.cc File extensions/browser/pref_names.cc (right): https://codereview.chromium.org/493003002/diff/1/extensions/browser/pref_names.cc#newcode33 extensions/browser/pref_names.cc:33: const char kAppFullscreenAllowed[] = "apps.fullscreen.allowed"; On 2014/08/21 04:49:16, ...
6 years, 4 months ago (2014-08-22 00:58:50 UTC) #2
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-22 02:24:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/493003002/1
6 years, 4 months ago (2014-08-22 02:24:57 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_tests_recipe on tryserver.chromium.linux ...
6 years, 4 months ago (2014-08-22 03:19:11 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-22 03:21:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/5978)
6 years, 4 months ago (2014-08-22 03:21:12 UTC) #7
hashimoto
bauerb@: Please review this change as an owner of chrome/browser/prefs/browser_prefs.cc. bartfab@: Please reivew this change ...
6 years, 4 months ago (2014-08-22 05:24:04 UTC) #8
Bernhard Bauer
prefs/ LGTM (feel free to TBR trivial changes like this if the overall CL has ...
6 years, 4 months ago (2014-08-22 18:08:04 UTC) #9
hashimoto
TBRing bartfab@chromium.org for include fix in configuration_policy_handler_list_factory.cc.
6 years, 4 months ago (2014-08-25 07:25:11 UTC) #10
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-25 07:25:14 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/493003002/1
6 years, 4 months ago (2014-08-25 07:26:05 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (1) as 3da4417c5baa6b8fe0be9aa012f0fd3294d9dbc7
6 years, 4 months ago (2014-08-25 08:19:23 UTC) #13
bartfab (slow)
configuration_policy_handler_list_factory.cc lgtm
6 years, 4 months ago (2014-08-25 08:44:17 UTC) #14
Michael Achenbach
A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/499253002/ by machenbach@chromium.org. The ...
6 years, 4 months ago (2014-08-25 08:45:27 UTC) #15
hashimoto
The CQ bit was checked by hashimoto@chromium.org
6 years, 4 months ago (2014-08-25 08:55:11 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/493003002/20001
6 years, 4 months ago (2014-08-25 08:55:46 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (20001) as 374e77b4c453ec23c72d1181b24dfe478a36f8da
6 years, 4 months ago (2014-08-25 11:08:36 UTC) #18
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/77b343e018d1ed88bc9ce96fc9a9055c2e1c5cde Cr-Commit-Position: refs/heads/master@{#291650}
6 years, 3 months ago (2014-09-10 02:33:22 UTC) #19
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:33:33 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2d1cf16698ef2680ea50014b015fecf6db32e730
Cr-Commit-Position: refs/heads/master@{#291655}

Powered by Google App Engine
This is Rietveld 408576698