Issue 492963008: Ash: Double-clicking on a shelf item now opens the item

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 492963008: Ash: Double-clicking on a shelf item now opens the item (Closed)

Created:
6 years, 4 months ago by James Cook

Modified:
6 years, 3 months ago

Reviewers:
Mr4D (OOO till 08-26)

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Ash: Double-clicking on a shelf item now opens the item Previously it would open the item then immediately minimize it. This caused user confusion because they tried a double-click and didn't see anything open on the screen. BUG=404060 TEST=ash_unittests ShelfViewTest.ClickingTwiceActivatesOnce Committed: https://crrev.com/4963830383cd11d5ad000504a3f9dcc49ec122d4 Cr-Commit-Position: refs/heads/master@{#291695}

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+79 lines, -11 lines)			Patch
M	ash/shelf/shelf_view.cc	View	1 chunk	+7 lines, -0 lines	0 comments	Download
M	ash/shelf/shelf_view_unittest.cc	View	8 chunks	+56 lines, -11 lines	0 comments	Download
M	ash/test/shelf_view_test_api.h	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	ash/test/shelf_view_test_api.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/492963008/1

6 years, 4 months ago (2014-08-25 15:42:13 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (1) as 4da302e10ab97486a72b55f519185a5f38d1f92b

6 years, 4 months ago (2014-08-25 16:36:43 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:34:58 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4963830383cd11d5ad000504a3f9dcc49ec122d4
Cr-Commit-Position: refs/heads/master@{#291695}

Expand Messages | Collapse Messages