Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Unified Diff: device/hid/hid_report_descriptor.cc

Issue 492963007: Store HID report sizes as uint16_t. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/hid/hid_report_descriptor.h ('k') | device/hid/hid_report_descriptor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/hid/hid_report_descriptor.cc
diff --git a/device/hid/hid_report_descriptor.cc b/device/hid/hid_report_descriptor.cc
index c461004923efcfaa2904db87f2b68b363e57b4d5..d8031d382e16e6771a275a637ba46ce196ee2dc9 100644
--- a/device/hid/hid_report_descriptor.cc
+++ b/device/hid/hid_report_descriptor.cc
@@ -29,9 +29,9 @@ HidReportDescriptor::~HidReportDescriptor() {}
void HidReportDescriptor::GetDetails(
std::vector<HidCollectionInfo>* top_level_collections,
bool* has_report_id,
- int* max_input_report_size,
- int* max_output_report_size,
- int* max_feature_report_size) {
+ uint16_t* max_input_report_size,
+ uint16_t* max_output_report_size,
+ uint16_t* max_feature_report_size) {
DCHECK(top_level_collections);
DCHECK(max_input_report_size);
DCHECK(max_output_report_size);
@@ -45,13 +45,13 @@ void HidReportDescriptor::GetDetails(
// Global tags data:
HidUsageAndPage::Page current_usage_page = HidUsageAndPage::kPageUndefined;
- int current_report_count = 0;
- int cached_report_count = 0;
- int current_report_size = 0;
- int cached_report_size = 0;
- int current_input_report_size = 0;
- int current_output_report_size = 0;
- int current_feature_report_size = 0;
+ uint16_t current_report_count = 0;
+ uint16_t cached_report_count = 0;
+ uint16_t current_report_size = 0;
+ uint16_t cached_report_size = 0;
+ uint16_t current_input_report_size = 0;
+ uint16_t current_output_report_size = 0;
+ uint16_t current_feature_report_size = 0;
// Local tags data:
uint16_t current_usage = 0;
« no previous file with comments | « device/hid/hid_report_descriptor.h ('k') | device/hid/hid_report_descriptor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698