Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3018)

Unified Diff: chrome/browser/search_engines/template_url_service_sync_unittest.cc

Issue 492963005: Stop using UIThreadSearchTermsData for search_engines related tests (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Use make_scoped_ptr Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/search_engines/template_url_service_test_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search_engines/template_url_service_sync_unittest.cc
diff --git a/chrome/browser/search_engines/template_url_service_sync_unittest.cc b/chrome/browser/search_engines/template_url_service_sync_unittest.cc
index aad5815a2f1cde6c999ad535e3c391f20aff0cd0..d2b8b2868b7c25228107b76c935759bff58fc101 100644
--- a/chrome/browser/search_engines/template_url_service_sync_unittest.cc
+++ b/chrome/browser/search_engines/template_url_service_sync_unittest.cc
@@ -10,10 +10,10 @@
#include "base/time/time.h"
#include "chrome/browser/search_engines/template_url_service_factory.h"
#include "chrome/browser/search_engines/template_url_service_test_util.h"
-#include "chrome/browser/search_engines/ui_thread_search_terms_data.h"
#include "chrome/test/base/testing_pref_service_syncable.h"
#include "chrome/test/base/testing_profile.h"
#include "components/search_engines/search_engines_pref_names.h"
+#include "components/search_engines/search_terms_data.h"
#include "components/search_engines/template_url.h"
#include "components/search_engines/template_url_prepopulate_data.h"
#include "components/search_engines/template_url_service.h"
@@ -237,8 +237,7 @@ void TemplateURLServiceSyncTest::SetUp() {
TemplateURLServiceFactory::GetInstance()->
RegisterUserPrefsOnBrowserContextForTest(profile_b_.get());
model_b_.reset(new TemplateURLService(
- profile_b_->GetPrefs(), scoped_ptr<SearchTermsData>(
- new UIThreadSearchTermsData(profile_b_.get())), NULL,
+ profile_b_->GetPrefs(), make_scoped_ptr(new SearchTermsData), NULL,
scoped_ptr<TemplateURLServiceClient>(), NULL, NULL, base::Closure()));
model_b_->Load();
}
@@ -1122,7 +1121,7 @@ TEST_F(TemplateURLServiceSyncTest, AutogeneratedKeywordMigrated) {
TemplateURL* key1 = model()->GetTemplateURLForHost("key1.com");
ASSERT_FALSE(key1 == NULL);
EXPECT_EQ(ASCIIToUTF16("key1.com"), key1->keyword());
- GURL google_url(UIThreadSearchTermsData(profile_a()).GoogleBaseURLValue());
+ GURL google_url(model()->search_terms_data().GoogleBaseURLValue());
TemplateURL* key2 = model()->GetTemplateURLForHost(google_url.host());
ASSERT_FALSE(key2 == NULL);
base::string16 google_keyword(net::StripWWWFromHost(google_url));
@@ -1144,7 +1143,7 @@ TEST_F(TemplateURLServiceSyncTest, AutogeneratedKeywordConflicts) {
// Sync brings in some autogenerated keywords, but the generated keywords we
// try to create conflict with ones in the model.
base::string16 google_keyword(net::StripWWWFromHost(GURL(
- UIThreadSearchTermsData(profile_a()).GoogleBaseURLValue())));
+ model()->search_terms_data().GoogleBaseURLValue())));
const std::string local_google_url =
"{google:baseURL}1/search?q={searchTerms}";
TemplateURL* google = CreateTestTemplateURL(google_keyword, local_google_url);
@@ -1217,7 +1216,7 @@ TEST_F(TemplateURLServiceSyncTest, TwoAutogeneratedKeywordsUsingGoogleBaseURL) {
// We should still have coalesced the updates to one each.
base::string16 google_keyword(net::StripWWWFromHost(GURL(
- UIThreadSearchTermsData(profile_a()).GoogleBaseURLValue())));
+ model()->search_terms_data().GoogleBaseURLValue())));
TemplateURL* keyword1 =
model()->GetTemplateURLForKeyword(google_keyword + ASCIIToUTF16("_"));
ASSERT_FALSE(keyword1 == NULL);
« no previous file with comments | « no previous file | chrome/browser/search_engines/template_url_service_test_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698