Issue 492963005: Stop using UIThreadSearchTermsData for search_engines related tests

Issue 492963005: Stop using UIThreadSearchTermsData for search_engines related tests (Closed)

Created:
6 years, 4 months ago by hashimoto

Modified:
6 years, 3 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Stop using UIThreadSearchTermsData for search_engines related tests Move TestingSearchTermsData from template_url_unittest.cc to a new file. Stop using UIThreadSearchTermsData for tests BUG=387985 TEST=unit_tests Committed: https://crrev.com/3c83181e37ea66c5743aef82d20ce8dcf024882f Cr-Commit-Position: refs/heads/master@{#291646}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Use make_scoped_ptr #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -135 lines)			Patch
M	chrome/browser/search_engines/template_url_service_sync_unittest.cc	View	1	5 chunks	+5 lines, -6 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_service_test_util.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_service_test_util.cc	View		5 chunks	+14 lines, -18 lines	0 comments	Download
M	chrome/browser/search_engines/template_url_service_unittest.cc	View		1 chunk	+0 lines, -24 lines	0 comments	Download
M	components/components_tests.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/search_engines.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	components/search_engines/template_url_unittest.cc	View		3 chunks	+5 lines, -87 lines	0 comments	Download
A	components/search_engines/testing_search_terms_data.h	View		1 chunk	+50 lines, -0 lines	0 comments	Download
A	components/search_engines/testing_search_terms_data.cc	View		1 chunk	+46 lines, -0 lines	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM https://codereview.chromium.org/492963005/diff/20001/chrome/browser/search_engines/template_url_service_sync_unittest.cc File chrome/browser/search_engines/template_url_service_sync_unittest.cc (right): https://codereview.chromium.org/492963005/diff/20001/chrome/browser/search_engines/template_url_service_sync_unittest.cc#newcode240 chrome/browser/search_engines/template_url_service_sync_unittest.cc:240: profile_b_->GetPrefs(), scoped_ptr<SearchTermsData>(new SearchTermsData), Nit: make_scoped_ptr() would be slightly ...

6 years, 4 months ago (2014-08-22 18:57:26 UTC) #2

hashimoto

https://codereview.chromium.org/492963005/diff/20001/chrome/browser/search_engines/template_url_service_sync_unittest.cc File chrome/browser/search_engines/template_url_service_sync_unittest.cc (right): https://codereview.chromium.org/492963005/diff/20001/chrome/browser/search_engines/template_url_service_sync_unittest.cc#newcode240 chrome/browser/search_engines/template_url_service_sync_unittest.cc:240: profile_b_->GetPrefs(), scoped_ptr<SearchTermsData>(new SearchTermsData), On 2014/08/22 18:57:26, Peter Kasting wrote: ...

6 years, 4 months ago (2014-08-25 05:45:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hashimoto@chromium.org/492963005/40001

6 years, 4 months ago (2014-08-25 05:45:50 UTC) #5

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...

6 years, 4 months ago (2014-08-25 06:55:30 UTC) #6

commit-bot: I haz the power

Committed patchset #2 (40001) as 551a18dc15588faa34bc3f1285c2cbfe2c313a0f

6 years, 4 months ago (2014-08-25 07:40:31 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:33:14 UTC) #8

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/3c83181e37ea66c5743aef82d20ce8dcf024882f
Cr-Commit-Position: refs/heads/master@{#291646}

Expand Messages | Collapse Messages