Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3042)

Unified Diff: crypto/crypto.gyp

Issue 492963004: Combine MSVS warning supression codes together in crypto.gyp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: incorporated the review comments Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: crypto/crypto.gyp
diff --git a/crypto/crypto.gyp b/crypto/crypto.gyp
index 3cdc151f3286ee1d78df7b46e27155353c3f9c89..b40e4142fe338529ee8e35ba1f8fa11dcc4e37ed 100644
--- a/crypto/crypto.gyp
+++ b/crypto/crypto.gyp
@@ -21,9 +21,6 @@
'defines': [
'CRYPTO_IMPLEMENTATION',
],
- 'msvs_disabled_warnings': [
- 4018,
- ],
'conditions': [
[ 'os_posix == 1 and OS != "mac" and OS != "ios" and OS != "android"', {
'dependencies': [
@@ -95,8 +92,10 @@
],
}],
[ 'OS == "win"', {
- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
- 'msvs_disabled_warnings': [4267, ],
+ 'msvs_disabled_warnings': [
+ 4267, # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
vivekg 2014/08/22 09:14:08 nit: Use single whitespace for the comment "4267,
+ 4018,
+ ],
}],
[ 'use_openssl==1', {
'dependencies': [
« no previous file with comments | « AUTHORS ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698