crypto/crypto.gyp - Issue 492963004: Combine MSVS warning supression codes together in crypto.gyp

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: crypto/crypto.gyp

Issue 492963004: Combine MSVS warning supression codes together in crypto.gyp (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: crypto/crypto.gyp

diff --git a/crypto/crypto.gyp b/crypto/crypto.gyp

index 3cdc151f3286ee1d78df7b46e27155353c3f9c89..fdcc0a85c8a477b4a3b6f857263002dd100815d3 100644

--- a/crypto/crypto.gyp

+++ b/crypto/crypto.gyp

@@ -21,9 +21,6 @@

'defines': [

'CRYPTO_IMPLEMENTATION',

- 'msvs_disabled_warnings': [

- 4018,

- ],

'conditions': [

[ 'os_posix == 1 and OS != "mac" and OS != "ios" and OS != "android"', {

'dependencies': [

@@ -95,8 +92,10 @@

}],

[ 'OS == "win"', {

- # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

- 'msvs_disabled_warnings': [4267, ],

+ 'msvs_disabled_warnings': [

+ 4267, # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.

+ 4018,

+ ]#,

vivekg 2014/08/22 07:49:14 Remove the stray '#'

}],

[ 'use_openssl==1', {

'dependencies': [

« no previous file with comments | « no previous file | no next file » | no next file with comments »