|
|
DescriptionCombine MSVS warning supression codes
together in crypto.gyp
"msvs_disabled_warnings" code definition present in two place in the same 'target_name': 'crypto'.
Committed: https://crrev.com/22ca86792d5afe3ca862578e60009d7850cd1f94
Cr-Commit-Position: refs/heads/master@{#291903}
Patch Set 1 #
Total comments: 1
Patch Set 2 : incorporated the review comments #
Total comments: 1
Patch Set 3 : Review comments are added #Patch Set 4 : Removed the entry from AUTHORs file #Patch Set 5 : #Messages
Total messages: 21 (0 generated)
PTAL
On 2014/08/22 at 07:29:27, kulkarni.a wrote: > PTAL Please give a descriptive title e.g. "Combine MSVS warning supression codes together in crypto.gyp" Also keep the title as the first line of the description as only the description entry is applied in the repository commit log.
https://codereview.chromium.org/492963004/diff/1/crypto/crypto.gyp File crypto/crypto.gyp (right): https://codereview.chromium.org/492963004/diff/1/crypto/crypto.gyp#newcode98 crypto/crypto.gyp:98: ]#, Remove the stray '#'
On 2014/08/22 07:49:15, vivekg_ wrote: > https://codereview.chromium.org/492963004/diff/1/crypto/crypto.gyp > File crypto/crypto.gyp (right): > > https://codereview.chromium.org/492963004/diff/1/crypto/crypto.gyp#newcode98 > crypto/crypto.gyp:98: ]#, > Remove the stray '#' Thanks for review. Review comments are incorporated . PTAL.
https://codereview.chromium.org/492963004/diff/20001/crypto/crypto.gyp File crypto/crypto.gyp (right): https://codereview.chromium.org/492963004/diff/20001/crypto/crypto.gyp#newcode96 crypto/crypto.gyp:96: 4267, # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. nit: Use single whitespace for the comment "4267, # TODO..." => "4267, # TODO..." see examples here: https://code.google.com/p/chromium/codesearch#search/&q=.*%5C,%5C%20%5C%23%20...
Also remove empty BUG= line from the description.
On 2014/08/22 09:14:31, vivekg_ wrote: > Also remove empty BUG= line from the description. PTAL
kulkarni.a@samsung.com changed reviewers: + agl@chromium.org, darin@chromium.org
agl@chromium.org: Please review changes in darin@chromium.org: Please review changes in PTAL
LGTM
The CQ bit was checked by darin@chromium.org
The CQ bit was unchecked by kulkarni.a@samsung.com
The CQ bit was checked by kulkarni.a@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kulkarni.a@samsung.com/492963004/40001
The CQ bit was checked by kulkarni.a@samsung.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kulkarni.a@samsung.com/492963004/80001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
Message was sent while issue was closed.
Committed patchset #5 (80001) as 7a8f8aa1e9e72313d4b9d8f1a7091298f6be1458
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/22ca86792d5afe3ca862578e60009d7850cd1f94 Cr-Commit-Position: refs/heads/master@{#291903} |