Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1193)

Issue 492963004: Combine MSVS warning supression codes together in crypto.gyp (Closed)

Created:
6 years, 4 months ago by ARUNKK
Modified:
6 years, 3 months ago
CC:
lgombos
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Combine MSVS warning supression codes together in crypto.gyp "msvs_disabled_warnings" code definition present in two place in the same 'target_name': 'crypto'. Committed: https://crrev.com/22ca86792d5afe3ca862578e60009d7850cd1f94 Cr-Commit-Position: refs/heads/master@{#291903}

Patch Set 1 #

Total comments: 1

Patch Set 2 : incorporated the review comments #

Total comments: 1

Patch Set 3 : Review comments are added #

Patch Set 4 : Removed the entry from AUTHORs file #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M crypto/crypto.gyp View 1 2 2 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
ARUNKK
PTAL
6 years, 4 months ago (2014-08-22 07:29:27 UTC) #1
vivekg
On 2014/08/22 at 07:29:27, kulkarni.a wrote: > PTAL Please give a descriptive title e.g. "Combine ...
6 years, 4 months ago (2014-08-22 07:48:53 UTC) #2
vivekg
https://codereview.chromium.org/492963004/diff/1/crypto/crypto.gyp File crypto/crypto.gyp (right): https://codereview.chromium.org/492963004/diff/1/crypto/crypto.gyp#newcode98 crypto/crypto.gyp:98: ]#, Remove the stray '#'
6 years, 4 months ago (2014-08-22 07:49:15 UTC) #3
ARUNKK
On 2014/08/22 07:49:15, vivekg_ wrote: > https://codereview.chromium.org/492963004/diff/1/crypto/crypto.gyp > File crypto/crypto.gyp (right): > > https://codereview.chromium.org/492963004/diff/1/crypto/crypto.gyp#newcode98 > ...
6 years, 4 months ago (2014-08-22 08:59:12 UTC) #4
vivekg
https://codereview.chromium.org/492963004/diff/20001/crypto/crypto.gyp File crypto/crypto.gyp (right): https://codereview.chromium.org/492963004/diff/20001/crypto/crypto.gyp#newcode96 crypto/crypto.gyp:96: 4267, # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. ...
6 years, 4 months ago (2014-08-22 09:14:08 UTC) #5
vivekg
Also remove empty BUG= line from the description.
6 years, 4 months ago (2014-08-22 09:14:31 UTC) #6
ARUNKK
On 2014/08/22 09:14:31, vivekg_ wrote: > Also remove empty BUG= line from the description. PTAL
6 years, 4 months ago (2014-08-22 09:56:36 UTC) #7
ARUNKK
kulkarni.a@samsung.com changed reviewers: - kphanee@chromium.org, l.gombos@samsung.com, siva.gunturi@samsung.com, sohan.jyoti@samsung.com, vivekg@chromium.org
6 years, 3 months ago (2014-08-26 05:53:12 UTC) #8
ARUNKK
6 years, 3 months ago (2014-08-26 05:53:12 UTC) #9
ARUNKK
kulkarni.a@samsung.com changed reviewers: + agl@chromium.org, darin@chromium.org
6 years, 3 months ago (2014-08-26 05:53:49 UTC) #10
ARUNKK
agl@chromium.org: Please review changes in darin@chromium.org: Please review changes in PTAL
6 years, 3 months ago (2014-08-26 05:53:49 UTC) #11
darin (slow to review)
LGTM
6 years, 3 months ago (2014-08-26 06:40:49 UTC) #12
darin (slow to review)
The CQ bit was checked by darin@chromium.org
6 years, 3 months ago (2014-08-26 06:40:55 UTC) #13
ARUNKK
The CQ bit was unchecked by kulkarni.a@samsung.com
6 years, 3 months ago (2014-08-26 06:42:05 UTC) #14
ARUNKK
The CQ bit was checked by kulkarni.a@samsung.com
6 years, 3 months ago (2014-08-26 06:42:08 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kulkarni.a@samsung.com/492963004/40001
6 years, 3 months ago (2014-08-26 06:42:38 UTC) #16
ARUNKK
The CQ bit was checked by kulkarni.a@samsung.com
6 years, 3 months ago (2014-08-26 09:47:00 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kulkarni.a@samsung.com/492963004/80001
6 years, 3 months ago (2014-08-26 09:47:41 UTC) #18
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel_swarming on tryserver.chromium.win ...
6 years, 3 months ago (2014-08-26 13:26:22 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (80001) as 7a8f8aa1e9e72313d4b9d8f1a7091298f6be1458
6 years, 3 months ago (2014-08-26 14:13:34 UTC) #20
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 02:42:50 UTC) #21
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/22ca86792d5afe3ca862578e60009d7850cd1f94
Cr-Commit-Position: refs/heads/master@{#291903}

Powered by Google App Engine
This is Rietveld 408576698