Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 492953002: cc: Stop checking the result of GetInverse in OcclusionTracker. (Closed)

Created:
6 years, 4 months ago by danakj
Modified:
6 years, 4 months ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org, piman, Ian Vollick
Project:
chromium
Visibility:
Public.

Description

cc: Stop checking the result of GetInverse in OcclusionTracker. We don't draw layers with non-invertible transforms, so this check is a waste. Especially in the case where we don't even use the inverse transform. R=enne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291242

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M cc/trees/occlusion_tracker.cc View 3 chunks +4 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
danakj
6 years, 4 months ago (2014-08-21 01:34:46 UTC) #1
enne (OOO)
lgtm Offhand, this seems like a common pattern for cc to not care about inverses. ...
6 years, 4 months ago (2014-08-21 17:36:11 UTC) #2
danakj
On 2014/08/21 17:36:11, enne wrote: > lgtm > > Offhand, this seems like a common ...
6 years, 4 months ago (2014-08-21 17:38:53 UTC) #3
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 4 months ago (2014-08-21 17:38:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/492953002/1
6 years, 4 months ago (2014-08-21 17:41:01 UTC) #5
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 23:28:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 291242

Powered by Google App Engine
This is Rietveld 408576698