Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 492943002: AnalysisCanvas is missing an override for virtual void onClipRegion (Closed)

Created:
6 years, 4 months ago by hendrikw
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

AnalysisCanvas is missing an override for virtual void onClipRegion BUG=405364 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291548

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -22 lines) Patch
M skia/ext/analysis_canvas.h View 2 chunks +5 lines, -1 line 0 comments Download
M skia/ext/analysis_canvas.cc View 2 chunks +25 lines, -21 lines 0 comments Download
M skia/ext/analysis_canvas_unittest.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hendrikw
I couldn't find a webpage that actually ran into this issue, but it's still good ...
6 years, 4 months ago (2014-08-21 00:24:19 UTC) #1
vmpstr
I think this is correct. From our discussion, we don't really have region clips, but ...
6 years, 4 months ago (2014-08-22 18:25:28 UTC) #2
hendrikw
+junov for owner review
6 years, 4 months ago (2014-08-22 18:32:03 UTC) #3
Justin Novosad
On 2014/08/22 18:32:03, Hendrik wrote: > +junov for owner review lgtm
6 years, 4 months ago (2014-08-22 21:19:23 UTC) #4
hendrikw
The CQ bit was checked by hendrikw@chromium.org
6 years, 4 months ago (2014-08-22 21:34:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hendrikw@chromium.org/492943002/1
6 years, 4 months ago (2014-08-22 21:34:56 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel_swarming on tryserver.chromium.win ...
6 years, 4 months ago (2014-08-22 22:30:52 UTC) #7
commit-bot: I haz the power
6 years, 4 months ago (2014-08-22 23:24:39 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (1) as 291548

Powered by Google App Engine
This is Rietveld 408576698