Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 492843003: [Android] Upstream BrowserVersion.java and related native code. (Closed)

Created:
6 years, 4 months ago by Feng Qian
Modified:
6 years, 4 months ago
Reviewers:
Lei Zhang, Yaron, gone
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

[Android] Upstream BrowserVersion.java and related native code. BUG=159202 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291027

Patch Set 1 #

Total comments: 13

Patch Set 2 : address reviewers' comments #

Total comments: 1

Patch Set 3 : remove an unused import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -0 lines) Patch
A chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java View 1 1 chunk +37 lines, -0 lines 0 comments Download
A chrome/browser/android/browser_version.h View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/browser/android/browser_version.cc View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/browser/android/chrome_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (0 generated)
Feng Qian
Downstream CL: https://chrome-internal-review.googlesource.com/#/c/173176/
6 years, 4 months ago (2014-08-20 18:30:57 UTC) #1
Yaron
+Dan since his name is all over this. https://codereview.chromium.org/492843003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java File chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java (right): https://codereview.chromium.org/492843003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java#newcode9 chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java:9: * ...
6 years, 4 months ago (2014-08-20 19:11:48 UTC) #2
Lei Zhang
https://codereview.chromium.org/492843003/diff/1/chrome/browser/android/browser_version.cc File chrome/browser/android/browser_version.cc (right): https://codereview.chromium.org/492843003/diff/1/chrome/browser/android/browser_version.cc#newcode8 chrome/browser/android/browser_version.cc:8: #include "base/logging.h" logging.h and resource_bundle.h are probably not needed. ...
6 years, 4 months ago (2014-08-20 19:25:06 UTC) #3
gone
https://codereview.chromium.org/492843003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java File chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java (right): https://codereview.chromium.org/492843003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java#newcode24 chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java:24: * TODO(dfalcantara): If/when we start using ProGuard, replace this ...
6 years, 4 months ago (2014-08-20 20:12:42 UTC) #4
Feng Qian
https://codereview.chromium.org/492843003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java File chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java (right): https://codereview.chromium.org/492843003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java#newcode9 chrome/android/java/src/org/chromium/chrome/browser/BrowserVersion.java:9: * Provides a way for java code to determine ...
6 years, 4 months ago (2014-08-20 21:34:29 UTC) #5
Yaron
lgtm
6 years, 4 months ago (2014-08-20 21:43:46 UTC) #6
Lei Zhang
lgtm https://codereview.chromium.org/492843003/diff/20001/chrome/browser/android/browser_version.cc File chrome/browser/android/browser_version.cc (right): https://codereview.chromium.org/492843003/diff/20001/chrome/browser/android/browser_version.cc#newcode12 chrome/browser/android/browser_version.cc:12: #include "ui/base/resource/resource_bundle.h" nit: not used either.
6 years, 4 months ago (2014-08-20 21:53:50 UTC) #7
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 4 months ago (2014-08-20 22:03:20 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/492843003/40001
6 years, 4 months ago (2014-08-20 22:05:14 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 23:54:27 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 23:58:15 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/55301) android_clang_dbg on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg/builds/8058)
6 years, 4 months ago (2014-08-20 23:58:16 UTC) #12
Feng Qian
The CQ bit was checked by feng@chromium.org
6 years, 4 months ago (2014-08-21 04:11:38 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/feng@chromium.org/492843003/40001
6 years, 4 months ago (2014-08-21 04:12:29 UTC) #14
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 09:31:26 UTC) #15
Message was sent while issue was closed. 
Committed patchset #3 (40001) as 291027

Powered by Google App Engine
This is Rietveld 408576698