Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(827)

Unified Diff: base/debug/trace_event_unittest.cc

Issue 492823002: Add OnBeforeTraceLogDisabled notification to EnabledStateObserver (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rename the callback to OnBeforeTraceLogDisabled Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/debug/trace_event_impl.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/debug/trace_event_unittest.cc
diff --git a/base/debug/trace_event_unittest.cc b/base/debug/trace_event_unittest.cc
index 581906b72e1d43e55a805210c57f6841cf90afa4..92328926d2835473f73e6f2701a07cb6724d4ed5 100644
--- a/base/debug/trace_event_unittest.cc
+++ b/base/debug/trace_event_unittest.cc
@@ -898,6 +898,7 @@ class MockEnabledStateChangedObserver :
public:
MOCK_METHOD0(OnTraceLogEnabled, void());
MOCK_METHOD0(OnTraceLogDisabled, void());
+ MOCK_METHOD0(OnBeforeTraceLogDisabled, void());
};
TEST_F(TraceEventTestFixture, EnabledObserverFiresOnEnable) {
@@ -931,6 +932,8 @@ TEST_F(TraceEventTestFixture, EnabledObserverDoesntFireOnSecondEnable) {
.Times(0);
EXPECT_CALL(observer, OnTraceLogDisabled())
.Times(0);
+ EXPECT_CALL(observer, OnBeforeTraceLogDisabled())
+ .Times(0);
TraceLog::GetInstance()->SetEnabled(
CategoryFilter("*"),
TraceLog::RECORDING_MODE,
@@ -962,6 +965,8 @@ TEST_F(TraceEventTestFixture, EnabledObserverFiresOnFirstDisable) {
.Times(0);
EXPECT_CALL(observer, OnTraceLogDisabled())
.Times(1);
+ EXPECT_CALL(observer, OnBeforeTraceLogDisabled())
+ .Times(1);
TraceLog::GetInstance()->SetDisabled();
testing::Mock::VerifyAndClear(&observer);
@@ -981,6 +986,8 @@ TEST_F(TraceEventTestFixture, EnabledObserverFiresOnDisable) {
EXPECT_CALL(observer, OnTraceLogDisabled())
.Times(1);
+ EXPECT_CALL(observer, OnBeforeTraceLogDisabled())
+ .Times(1);
TraceLog::GetInstance()->SetDisabled();
testing::Mock::VerifyAndClear(&observer);
@@ -1003,6 +1010,10 @@ class AfterStateChangeEnabledStateObserver
virtual void OnTraceLogDisabled() OVERRIDE {
EXPECT_FALSE(TraceLog::GetInstance()->IsEnabled());
}
+
+ virtual void OnBeforeTraceLogDisabled() OVERRIDE {
+ EXPECT_TRUE(TraceLog::GetInstance()->IsEnabled());
+ }
};
TEST_F(TraceEventTestFixture, ObserversFireAfterStateChange) {
« no previous file with comments | « base/debug/trace_event_impl.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698