Ensure that "Always Run" context menu item dissapears upon granting

chrome/browser/extensions/active_script_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/active_script_controller.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/metrics/histogram.h"
@@ skipping 121 matching lines @@
   // TODO(devlin): Make sure that the permission is removed from
   // withheld_permissions if appropriate.
   PermissionsUpdater(web_contents()->GetBrowserContext())
       .AddPermissions(extension, new_permissions.get());
 
   // Allow current tab to run injection.
   OnClicked(extension);
 }
 
 bool ActiveScriptController::HasActiveScriptAction(const Extension* extension) {
-  return enabled_ && active_script_actions_.count(extension->id()) > 0;
+  return enabled_ && pending_requests_.count(extension->id()) > 0;

[not at google - send to devlin, 2014/08/20 20:27:07]

active_script_actions_ seems like the right check to me? Is something else going
wrong?

I'm going to give this to Devlin, I need to finish something else off.

 }
 
 ExtensionAction* ActiveScriptController::GetActionForExtension(
     const Extension* extension) {
   if (!enabled_ || pending_requests_.count(extension->id()) == 0)
     return NULL;  // No action for this extension.
 
   ActiveScriptMap::iterator existing =
       active_script_actions_.find(extension->id());
   if (existing != active_script_actions_.end())
     return existing->second.get();
 
   linked_ptr<ExtensionAction> action(ExtensionActionManager::Get(
       Profile::FromBrowserContext(web_contents()->GetBrowserContext()))
       ->GetBestFitAction(*extension, ActionInfo::TYPE_PAGE).release());
   action->SetIsVisible(ExtensionAction::kDefaultTabId, true);
 
   active_script_actions_[extension->id()] = action;

[gpdavis, 2014/08/21 21:39:11]

active_script_actions_ is only manipulated in this method.

Codesearch is not working properly, but the comment for active_script_actions_
says:
// Script badges that have been generated for extensions. This is both those
// with actions already declared that are copied and normalised, and actions
// that get generated for extensions that haven't declared anything.

Seems like we ought to be removing the extension's entry in
active_script_actions_ in OnClicked.  What do you think?

   return action.get();
 }
 
 ExtensionAction::ShowAction ActiveScriptController::OnClicked(
     const Extension* extension) {
   DCHECK(ContainsKey(pending_requests_, extension->id()));
   RunPendingForExtension(extension);
   return ExtensionAction::ACTION_NONE;
 }
 
@@ skipping 175 matching lines @@
     UMA_HISTOGRAM_COUNTS_100(
         "Extensions.ActiveScriptController.PermittedExtensions",
         permitted_extensions_.size());
     UMA_HISTOGRAM_COUNTS_100(
         "Extensions.ActiveScriptController.DeniedExtensions",
         pending_requests_.size());
   }
 }
 
 }  // namespace extensions