Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: dart/tests/standalone/io/http_client_stays_alive_test.dart

Issue 492743003: Increase timeout from 2 to 10 seconds (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/tests/standalone/io/http_client_stays_alive_test.dart
diff --git a/dart/tests/standalone/io/http_client_stays_alive_test.dart b/dart/tests/standalone/io/http_client_stays_alive_test.dart
index eec24d348d01cad88500a0af56eb3d0c79f2de61..64ced6e16352c93fe813a937d9624a722ebdb2fe 100644
--- a/dart/tests/standalone/io/http_client_stays_alive_test.dart
+++ b/dart/tests/standalone/io/http_client_stays_alive_test.dart
@@ -15,7 +15,7 @@ import "package:async_helper/async_helper.dart";
// [HttpClient.idleTimeout] and the main script will assert that this happens
// within +/- 2 <= seconds.
-const SECONDS = 10;
+const SECONDS = 4;
void runServerProcess() {
asyncStart();
@@ -42,7 +42,7 @@ void runServerProcess() {
// NOTE: There is a slight chance this will cause flakiness, but there is
// no other good way of testing correctness of timing-dependent code
// form the outside.
- if ((SECONDS - seconds).abs() > 2) {
+ if (seconds < SECONDS || (SECONDS + 10) < seconds) {
throw "Child did exit within $seconds seconds, but expected it to take "
"roughly $SECONDS seconds.";
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698