Issue 492713002: Revert 290810 "Make class lookup lazy in jni_generator when usin..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 492713002: Revert 290810 "Make class lookup lazy in jni_generator when usin..." (Closed)

Created:
6 years, 4 months ago by ygorshenin1

Modified:
6 years, 4 months ago

Reviewers:
mkosiba (inactive)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 290810 "Make class lookup lazy in jni_generator when usin..." > Make class lookup lazy in jni_generator when using lazy method lookup. > > This removes the eager class registration from RegisterNatives when possible. > > BUG=402003 > TBR=sievers@chromium.org, brettw@chromium.org > > Review URL: https://codereview.chromium.org/472553002 TBR=mkosiba@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290813

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+371 lines, -707 lines)			Patch
M	trunk/src/android_webview/lib/main/webview_entry_point.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	trunk/src/base/BUILD.gn	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	trunk/src/base/android/base_jni_registrar.cc	View	2 chunks	+0 lines, -2 lines	0 comments	Download
D	trunk/src/base/android/java/src/org/chromium/base/JNIUtils.java	View	1 chunk	+0 lines, -20 lines	0 comments	Download
M	trunk/src/base/android/jni_android.h	View	2 chunks	+0 lines, -20 lines	0 comments	Download
M	trunk/src/base/android/jni_android.cc	View	3 chunks	+1 line, -56 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/golden_sample_for_tests_jni.h	View	14 chunks	+25 lines, -35 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/jni_generator.py	View	7 chunks	+14 lines, -47 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testCalledByNatives.golden	View	22 chunks	+41 lines, -50 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testConstantsFromJavaP.golden	View	88 chunks	+193 lines, -201 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testEagerCalledByNativesOption.golden	View	7 chunks	+10 lines, -19 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testFromJavaP.golden	View	12 chunks	+23 lines, -31 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testFromJavaPGenerics.golden	View	3 chunks	+3 lines, -11 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testInnerClassNatives.golden	View	3 chunks	+3 lines, -11 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testInnerClassNativesBothInnerAndOuter.golden	View	3 chunks	+5 lines, -13 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testInnerClassNativesMultiple.golden	View	3 chunks	+5 lines, -13 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testJNIInitNativeNameOption.golden	View	3 chunks	+3 lines, -11 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testJarJarRemapping.golden	View	3 chunks	+3 lines, -11 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testMultipleJNIAdditionalImport.golden	View	5 chunks	+7 lines, -15 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testNativeExportsOption.golden	View	10 chunks	+18 lines, -30 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testNatives.golden	View	3 chunks	+3 lines, -11 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testNativesLong.golden	View	3 chunks	+3 lines, -11 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testPureNativeMethodsOption.golden	View	3 chunks	+3 lines, -11 lines	0 comments	Download
M	trunk/src/base/android/jni_generator/testSingleJNIAdditionalImport.golden	View	5 chunks	+7 lines, -15 lines	0 comments	Download
D	trunk/src/base/android/jni_utils.h	View	1 chunk	+0 lines, -27 lines	0 comments	Download
D	trunk/src/base/android/jni_utils.cc	View	1 chunk	+0 lines, -25 lines	0 comments	Download
M	trunk/src/base/base.gyp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/base/base.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	trunk/src/ui/gl/android/scoped_java_surface.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ygorshenin1

6 years, 4 months ago (2014-08-20 11:44:33 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r290813 (tree was closed).

Expand Messages | Collapse Messages