Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 492703003: Adding the code inside extension flag to avoid build breaks. (Closed)

Created:
6 years, 4 months ago by Jitu( very slow this week)
Modified:
6 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding the code inside extension flag to avoid build breaks. While ENABLE_NOTIFICATION flag is enabled for android and ENABLE_EXTENSION flag is disable build breaks happens for function IsExtensionWithPermissionOrSuggestionInConsole() as this function is defined inside suggest_permission_util.h, which is inside extension flag. This patch is moved the code to proper flag. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291052

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Jitu( very slow this week)
PTAL
6 years, 4 months ago (2014-08-20 09:41:26 UTC) #1
Bernhard Bauer
lgtm
6 years, 4 months ago (2014-08-20 16:58:12 UTC) #2
Jitu( very slow this week)
The CQ bit was checked by jitendra.ks@samsung.com
6 years, 4 months ago (2014-08-21 05:20:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jitendra.ks@samsung.com/492703003/1
6 years, 4 months ago (2014-08-21 05:20:28 UTC) #4
commit-bot: I haz the power
6 years, 4 months ago (2014-08-21 12:08:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (1) as 291052

Powered by Google App Engine
This is Rietveld 408576698