Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 492693004: Delete Privet filesystem code (Closed)

Created:
6 years, 3 months ago by Noam Samuel
Modified:
6 years, 3 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Delete Privet filesystem code The Privet filesystem code is unmaintained, and it isn't aligned with PrivetV3. Remove it for now. BUG= Committed: https://crrev.com/ee53aabbe77593434b57544f54c3f771f37657e7 Cr-Commit-Position: refs/heads/master@{#292491}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1582 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.h View 1 2 3 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/file_manager/volume_manager.cc View 1 4 chunks +0 lines, -31 lines 0 comments Download
M chrome/browser/local_discovery/privet_http.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_impl.cc View 1 2 chunks +0 lines, -24 lines 0 comments Download
M chrome/browser/local_discovery/privet_http_unittest.cc View 1 2 2 chunks +0 lines, -20 lines 0 comments Download
D chrome/browser/local_discovery/storage/path_util.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/local_discovery/storage/path_util.cc View 1 chunk +0 lines, -87 lines 0 comments Download
D chrome/browser/local_discovery/storage/path_util_unittest.cc View 1 chunk +0 lines, -26 lines 0 comments Download
D chrome/browser/local_discovery/storage/privet_filesystem_async_util.h View 1 1 chunk +0 lines, -93 lines 0 comments Download
D chrome/browser/local_discovery/storage/privet_filesystem_async_util.cc View 1 1 chunk +0 lines, -173 lines 0 comments Download
D chrome/browser/local_discovery/storage/privet_filesystem_attribute_cache.h View 1 chunk +0 lines, -38 lines 0 comments Download
D chrome/browser/local_discovery/storage/privet_filesystem_attribute_cache.cc View 1 chunk +0 lines, -68 lines 0 comments Download
D chrome/browser/local_discovery/storage/privet_filesystem_attribute_cache_unittest.cc View 1 chunk +0 lines, -63 lines 0 comments Download
D chrome/browser/local_discovery/storage/privet_filesystem_backend.h View 1 1 chunk +0 lines, -76 lines 0 comments Download
D chrome/browser/local_discovery/storage/privet_filesystem_backend.cc View 1 1 chunk +0 lines, -110 lines 0 comments Download
D chrome/browser/local_discovery/storage/privet_filesystem_constants.h View 1 chunk +0 lines, -23 lines 0 comments Download
D chrome/browser/local_discovery/storage/privet_filesystem_constants.cc View 1 chunk +0 lines, -18 lines 0 comments Download
D chrome/browser/local_discovery/storage/privet_filesystem_operations.h View 1 1 chunk +0 lines, -176 lines 0 comments Download
D chrome/browser/local_discovery/storage/privet_filesystem_operations.cc View 1 1 chunk +0 lines, -288 lines 0 comments Download
D chrome/browser/local_discovery/storage/privet_volume_lister.h View 1 chunk +0 lines, -73 lines 0 comments Download
D chrome/browser/local_discovery/storage/privet_volume_lister.cc View 1 1 chunk +0 lines, -123 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
Noam Samuel
noamsml@chromium.org changed reviewers: + mtomasz@chromium.org, thestig@chromium.org, vitalybuka@chromium.org
6 years, 3 months ago (2014-08-26 23:22:14 UTC) #1
Noam Samuel
6 years, 3 months ago (2014-08-26 23:22:14 UTC) #2
Noam Samuel
noamsml@chromium.org changed reviewers: + mtomasz@chromium.org, thestig@chromium.org, vitalybuka@chromium.org
6 years, 3 months ago (2014-08-26 23:22:14 UTC) #3
Noam Samuel
6 years, 3 months ago (2014-08-26 23:22:14 UTC) #4
Lei Zhang
lgtm
6 years, 3 months ago (2014-08-27 00:37:22 UTC) #5
mtomasz
On 2014/08/27 00:37:22, Lei Zhang wrote: > lgtm Are you going to reimplement the privet ...
6 years, 3 months ago (2014-08-27 00:50:35 UTC) #6
Vitaly Buka (NO REVIEWS)
lgtm
6 years, 3 months ago (2014-08-27 01:00:25 UTC) #7
Noam Samuel
On 2014/08/27 01:00:25, Vitaly Buka wrote: > lgtm Re mtomasz: Right now the GCD project's ...
6 years, 3 months ago (2014-08-27 17:48:09 UTC) #8
mtomasz
Is there any crbug issue related, if so please fill out BUG=. lgtm.
6 years, 3 months ago (2014-08-28 00:27:40 UTC) #9
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 3 months ago (2014-08-28 18:07:54 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/492693004/1
6 years, 3 months ago (2014-08-28 18:08:40 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 3 months ago (2014-08-28 18:22:24 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 18:25:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/47721) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/10102) ios_rel_device ...
6 years, 3 months ago (2014-08-28 18:25:01 UTC) #14
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 3 months ago (2014-08-28 18:56:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/492693004/20001
6 years, 3 months ago (2014-08-28 18:58:07 UTC) #16
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux ...
6 years, 3 months ago (2014-08-28 19:56:14 UTC) #17
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 3 months ago (2014-08-28 20:05:02 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_rel on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel/builds/7117) win_chromium_x64_rel_swarming on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_swarming/builds/4148)
6 years, 3 months ago (2014-08-28 20:05:03 UTC) #19
Noam Samuel
The CQ bit was checked by noamsml@chromium.org
6 years, 3 months ago (2014-08-28 21:05:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noamsml@chromium.org/492693004/40001
6 years, 3 months ago (2014-08-28 21:07:19 UTC) #21
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: ios_dbg_simulator on tryserver.chromium.mac ...
6 years, 3 months ago (2014-08-28 22:12:02 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001) as a24fe3edaff6e83e23ff94f93343653945a4073b
6 years, 3 months ago (2014-08-28 23:25:20 UTC) #23
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:03:17 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ee53aabbe77593434b57544f54c3f771f37657e7
Cr-Commit-Position: refs/heads/master@{#292491}

Powered by Google App Engine
This is Rietveld 408576698