Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 492693003: Remove SkImageFilter::Set/GetExternalCache. (Closed)

Created:
6 years, 3 months ago by Stephen White
Modified:
6 years, 3 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Remove SkImageFilter::Set/GetExternalCache. These were removed from the .cpp in be129b26f13d575fd6b396c6ae759838ecc9bd1a, but I forgot to remove them from the header. R=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/8a914a76501d0bb4c60f8dbd1ae39c864688695b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M include/core/SkImageFilter.h View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Stephen White
Brian: PTAL. Thanks!
6 years, 3 months ago (2014-08-26 20:42:31 UTC) #1
reed1
reed@google.com changed reviewers: + reed@google.com
6 years, 3 months ago (2014-08-26 20:53:07 UTC) #2
reed1
lgtm
6 years, 3 months ago (2014-08-26 20:53:07 UTC) #3
Stephen White
The CQ bit was checked by senorblanco@chromium.org
6 years, 3 months ago (2014-08-26 20:53:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/senorblanco@chromium.org/492693003/1
6 years, 3 months ago (2014-08-26 20:54:07 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-08-26 21:06:05 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (1) as 8a914a76501d0bb4c60f8dbd1ae39c864688695b

Powered by Google App Engine
This is Rietveld 408576698