Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 492623004: Put PrintingUIWebContentsObserver and PrintingMessageFilter into printing namespace. (Closed)

Created:
6 years, 4 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 4 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Put PrintingUIWebContentsObserver and PrintingMessageFilter into printing namespace. BUG=374321 TBR=noamsml Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290815

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -66 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/printing/print_job_worker.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/printing/print_job_worker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/printing/printer_query.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.h View 4 chunks +18 lines, -20 lines 0 comments Download
M chrome/browser/printing/printing_message_filter.cc View 17 chunks +42 lines, -37 lines 0 comments Download
M chrome/browser/printing/printing_ui_web_contents_observer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/printing/printing_ui_web_contents_observer.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 4 months ago (2014-08-20 09:46:12 UTC) #1
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-20 09:46:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/492623004/20001
6 years, 4 months ago (2014-08-20 09:47:02 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 4 months ago (2014-08-20 09:55:28 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 4 months ago (2014-08-20 09:56:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg/builds/7635) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/5038)
6 years, 4 months ago (2014-08-20 09:56:44 UTC) #6
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-20 10:31:39 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/492623004/20001
6 years, 4 months ago (2014-08-20 10:32:06 UTC) #8
Vitaly Buka (NO REVIEWS)
The CQ bit was unchecked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-20 10:37:40 UTC) #9
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 4 months ago (2014-08-20 10:37:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/492623004/1
6 years, 4 months ago (2014-08-20 10:38:56 UTC) #11
commit-bot: I haz the power
6 years, 4 months ago (2014-08-20 11:48:48 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (1) as 290815

Powered by Google App Engine
This is Rietveld 408576698