Issue 492623003: Move BrowserWindowPropertyManager tests to interactive_ui_tests and reenable.

Issue 492623003: Move BrowserWindowPropertyManager tests to interactive_ui_tests and reenable. (Closed)

Created:
6 years, 4 months ago by calamity

Modified:
6 years, 3 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Move BrowserWindowPropertyManager tests to interactive_ui_tests and reenable. This test was flaky because it modified system properties. Moving it to interactive_ui_tests should allow it the system control guarantees it needs to complete successfully. BUG=396344 Committed: https://crrev.com/ececc5a2250a280a9a7a5e745b6e4eeedacf3dfb Cr-Commit-Position: refs/heads/master@{#291860}

Patch Set 1 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	chrome/chrome_tests.gypi	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

calamity

calamity@chromium.org changed reviewers: + sky@chromium.org

6 years, 4 months ago (2014-08-26 04:08:21 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/492623003/1

6 years, 3 months ago (2014-08-26 04:35:24 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (1) as 4d5d5d700a104f5e6bec47a8891fc5a54a4f242b

6 years, 3 months ago (2014-08-26 07:15:30 UTC) #6

jabdelmalek

A revert of this CL (patchset #1) has been created in https://codereview.chromium.org/504253002/ by jabdelmalek@google.com. The ...

6 years, 3 months ago (2014-08-26 15:59:18 UTC) #7

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 02:41:10 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ececc5a2250a280a9a7a5e745b6e4eeedacf3dfb
Cr-Commit-Position: refs/heads/master@{#291860}

Expand Messages | Collapse Messages