Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: content/browser/loader/upload_data_stream_builder.h

Issue 492603002: Move SetUserData of BlobDataHandles from UploadDataStreamBuilder to ResourceDispatcherHostImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: added comments in upload_data_stream_builder.h Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/upload_data_stream_builder.h
diff --git a/content/browser/loader/upload_data_stream_builder.h b/content/browser/loader/upload_data_stream_builder.h
index 7755e14c529f61f85e768abb434a093b55dc868b..228aade7979813c9f1db1f5766b3422b929917b8 100644
--- a/content/browser/loader/upload_data_stream_builder.h
+++ b/content/browser/loader/upload_data_stream_builder.h
@@ -32,10 +32,10 @@ class CONTENT_EXPORT UploadDataStreamBuilder {
public:
// Creates a new UploadDataStream from this request body.
//
- // This also resolves any blob references using the given |blob_context|
- // and binds those blob references to the ResourceRequestBody ensuring that
- // the blob data remains valid for the lifetime of the ResourceRequestBody
- // object.
+ // If |body| contains any blob references, the caller is responsible for
+ // making sure them outlive the returned value of UploadDataStream. We do this
+ // by binding the BlobDataHandles of them to ResourceRequestBody in
+ // ResourceDispatcherHostImpl::BeginRequest().
//
// |file_system_context| is used to create a FileStreamReader for files with
// filesystem URLs. |file_task_runner| is used to perform file operations
« no previous file with comments | « content/browser/loader/resource_dispatcher_host_impl.cc ('k') | content/browser/loader/upload_data_stream_builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698