pkg/analysis_server/lib/src/services/refactoring/rename_import.dart - Issue 492563002: Make more use of generated classes in analysis server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/refactoring/rename_import.dart

Issue 492563002: Make more use of generated classes in analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/analysis_server/lib/src/edit/edit_domain.dart ('K') | « pkg/analysis_server/lib/src/services/refactoring/rename_constructor.dart ('k') | pkg/analysis_server/test/analysis/get_errors_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/refactoring/rename_import.dart

diff --git a/pkg/analysis_server/lib/src/services/refactoring/rename_import.dart b/pkg/analysis_server/lib/src/services/refactoring/rename_import.dart

index 0dbb16481e2ad41f83aa74faed4f5e1c8d7a376b..f91b4fd3a63b8cf56b4f490de1e83085a677292b 100644

--- a/pkg/analysis_server/lib/src/services/refactoring/rename_import.dart

+++ b/pkg/analysis_server/lib/src/services/refactoring/rename_import.dart

@@ -6,6 +6,7 @@ library services.src.refactoring.rename_import;

import 'dart:async';

+import 'package:analysis_server/src/protocol2.dart';

import 'package:analysis_server/src/services/correction/change.dart';

import 'package:analysis_server/src/services/correction/status.dart';

import 'package:analysis_server/src/services/refactoring/refactoring.dart';

@@ -52,21 +53,21 @@ class RenameImportRefactoringImpl extends RenameRefactoringImpl {

{

String file = getElementFile(element);

PrefixElement prefix = element.prefix;

- Edit edit = null;

+ SourceEdit edit = null;

if (newName.isEmpty) {

int uriEnd = element.uriEnd;

int prefixEnd = element.prefixOffset + prefix.displayName.length;

SourceRange range = rangeStartEnd(uriEnd, prefixEnd);

- edit = new Edit.range(range, "");

+ edit = editFromRange(range, "");

} else {

if (prefix == null) {

SourceRange range = rangeStartLength(element.uriEnd, 0);

- edit = new Edit.range(range, " as ${newName}");

+ edit = editFromRange(range, " as ${newName}");

} else {

int offset = element.prefixOffset;

int length = prefix.displayName.length;

SourceRange range = rangeStartLength(offset, length);

- edit = new Edit.range(range, newName);

+ edit = editFromRange(range, newName);

}

if (edit != null) {

@@ -77,7 +78,7 @@ class RenameImportRefactoringImpl extends RenameRefactoringImpl {

return searchEngine.searchReferences(element).then((refMatches) {

List<SourceReference> references = getSourceReferences(refMatches);

for (SourceReference reference in references) {

- Edit edit;

+ SourceEdit edit;

if (newName.isEmpty) {

edit = createReferenceEdit(reference, newName);

} else {