Issue 492523002: Fixed command line parting when no output is needed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 492523002: Fixed command line parting when no output is needed. (Closed)

Created:
6 years, 4 months ago by Vitaly Buka (NO REVIEWS)

Modified:
6 years, 4 months ago

Reviewers:
Bo Xu, inferno

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Visibility:
Public.

More Reviews

Description

Fixed command line parting when no output is needed. R=bo_xu@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/8cf33bc

Patch Set 1 : Tue Aug 19 14:14:39 PDT 2014 #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	samples/pdfium_test.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vitaly Buka (NO REVIEWS)

Committed patchset #1 manually as 8cf33bc (presubmit successful).

6 years, 4 months ago (2014-08-19 21:22:24 UTC) #3

Bo Xu

6 years, 4 months ago (2014-08-19 21:22:47 UTC) #4

Message was sent while issue was closed.

On 2014/08/19 21:20:04, Bo Xu wrote:
> On 2014/08/19 21:14:54, Vitaly Buka wrote:
> 
> lgtm

I am thinking, if some one write: pdfium_test --ppm --bmp --emf a.pdf, shall we
output all three types of output files?

Expand Messages | Collapse Messages