Fix BrowserActionContainer chevron visibility regression

chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc

Index: chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
diff --git a/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc b/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
index bc94ac0e782344f6465bf6162c886f458041809d..53a57c223c346c28f822a6de035ef33db0daa439 100644
--- a/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
+++ b/chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc
@@ -217,6 +217,18 @@ IN_PROC_BROWSER_TEST_F(BrowserActionsContainerTest, Visibility) {
   EXPECT_EQ(3, browser_actions_bar()->NumberOfBrowserActions());
   EXPECT_EQ(3, browser_actions_bar()->VisibleBrowserActions());
   EXPECT_EQ(idA, browser_actions_bar()->GetExtensionId(0));
+
+  // Shrink the browser actions bar to zero visible icons.
+  // No icons should be visible, but we *should* show the chevron and have a
+  // non-empty size.
+  browser_actions_bar()->SetIconVisibilityCount(0);
+  EXPECT_EQ(0, browser_actions_bar()->VisibleBrowserActions());
+  BrowserActionsContainer* container =
+      BrowserView::GetBrowserViewForBrowser(browser())
+          ->toolbar()->browser_actions();
+  ASSERT_TRUE(container->chevron());
+  EXPECT_TRUE(container->chevron()->visible());
+  EXPECT_NE(container->GetPreferredSize(), gfx::Size());

[Peter Kasting, 2014/08/25 19:33:47]

Nit: (expected, actual)

Or you could do EXPECT_FALSE(container->GetPreferredSize().IsEmpty());

[Devlin, 2014/08/25 19:45:51]

Done.

 }
 
 IN_PROC_BROWSER_TEST_F(BrowserActionsContainerTest, ForceHide) {