Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Unified Diff: components/metrics/metrics_state_manager.cc

Issue 492463002: Remove DCHECKs that no longer reflect reality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/metrics/metrics_state_manager.cc
===================================================================
--- components/metrics/metrics_state_manager.cc (revision 290604)
+++ components/metrics/metrics_state_manager.cc (working copy)
@@ -162,7 +162,6 @@
if (IsMetricsReportingEnabled()) {
if (entropy_source_returned_ == ENTROPY_SOURCE_NONE)
entropy_source_returned_ = ENTROPY_SOURCE_HIGH;
Ilya Sherman 2014/08/19 21:04:14 Is this if stmt, as well as the one below, still c
Alexei Svitkine (slow) 2014/08/19 21:10:25 Yes, the field is documented to track the first va
- DCHECK_EQ(ENTROPY_SOURCE_HIGH, entropy_source_returned_);
const std::string high_entropy_source =
client_id_ + base::IntToString(low_entropy_source_value);
return scoped_ptr<const base::FieldTrial::EntropyProvider>(
@@ -171,7 +170,6 @@
if (entropy_source_returned_ == ENTROPY_SOURCE_NONE)
entropy_source_returned_ = ENTROPY_SOURCE_LOW;
- DCHECK_EQ(ENTROPY_SOURCE_LOW, entropy_source_returned_);
#if defined(OS_ANDROID) || defined(OS_IOS)
return scoped_ptr<const base::FieldTrial::EntropyProvider>(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698