Issue 492453002: Make it clear a DocumentNameCollection can only contain HTMLElements

Issue 492453002: Make it clear a DocumentNameCollection can only contain HTMLElements (Closed)

Created:
6 years, 4 months ago by Inactive

Modified:
6 years, 4 months ago

Reviewers:
haraken, adamk

CC:
blink-reviews, blink-reviews-html_chromium.org, arv+blink, sof, eae+blinkwatch, abarth-chromium, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Make it clear a DocumentNameCollection can only contain HTMLElements Make it clear a DocumentNameCollection can only contain HTMLElements. Only pass HTMLElements to DocumentNameCollection::elementMatches() as DocumentNameCollection can only contain HTMLElements. DocumentNameCollection was being handled in HTMLCollection::elementMatches() as matching any time of Elements, which was inaccurate. Its handling is now moved to isMatchingHTMLElement(), with other collections matching only HTMLElements. DocumentNameCollection::item() also now returns an HTMLElement instead of an Element. R=adamk@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180653

Patch Set 1 #

Patch Set 2 : Clean up #

Created: 6 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -9 lines)			Patch
M	Source/bindings/core/v8/WindowProxy.cpp	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/dom/Document.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	Source/core/dom/Document.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/DocumentNameCollection.h	View	1	2 chunks	+4 lines, -1 line	0 comments	Download
M	Source/core/html/DocumentNameCollection.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/html/HTMLCollection.cpp	View		3 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/492453002/20001

6 years, 4 months ago (2014-08-20 15:17:25 UTC) #4

commit-bot: I haz the power

Committed patchset #2 (20001) as 180653

6 years, 4 months ago (2014-08-20 15:20:47 UTC) #5

dglazkov

On 2014/08/20 at 15:20:47, commit-bot wrote: > Committed patchset #2 (20001) as 180653 It looks ...

6 years, 4 months ago (2014-08-20 20:26:18 UTC) #6

Message was sent while issue was closed.

On 2014/08/20 at 15:20:47, commit-bot wrote:
> Committed patchset #2 (20001) as 180653

It looks like this change _may have_ broken
https://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28db...

C  263.171s Main  [FAIL]
org.chromium.content.browser.input.ImeTest#testEnterKeyEventWhileComposingText:
C  263.171s Main  junit.framework.AssertionFailedError
C  263.171s Main  	at
org.chromium.content.browser.input.ImeTest.waitAndVerifyEditableCallback(ImeTest.java:557)
C  263.171s Main  	at
org.chromium.content.browser.input.ImeTest.testEnterKeyEventWhileComposingText(ImeTest.java:491)
C  263.171s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C  263.171s Main  	at
android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C  263.171s Main  	at
android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C  263.171s Main  	at
android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C  263.171s Main  	at
org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:227)
C  263.171s Main  	at
android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  263.171s Main  	at
android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  263.171s Main  	at
android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C  263.171s Main  	at
android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
C  263.171s Main  [FAIL]
org.chromium.content.browser.input.ImeTest#testFinishComposingText:
C  263.171s Main  junit.framework.AssertionFailedError
C  263.171s Main  	at
org.chromium.content.browser.input.ImeTest.waitAndVerifyEditableCallback(ImeTest.java:557)
C  263.171s Main  	at
org.chromium.content.browser.input.ImeTest.testFinishComposingText(ImeTest.java:247)
C  263.171s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C  263.171s Main  	at
android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C  263.171s Main  	at
android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C  263.171s Main  	at
android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C  263.171s Main  	at
org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:227)
C  263.172s Main  	at
android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  263.172s Main  	at
android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  263.172s Main  	at
android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C  263.172s Main  	at
android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
C  263.172s Main  [FAIL]
org.chromium.content.browser.input.ImeTest#testKeyCodesWhileComposingText:
C  263.172s Main  junit.framework.AssertionFailedError
C  263.172s Main  	at
org.chromium.content.browser.input.ImeTest.assertUpdateStateCall(ImeTest.java:581)
C  263.172s Main  	at
org.chromium.content.browser.input.ImeTest.testKeyCodesWhileComposingText(ImeTest.java:329)
C  263.172s Main  	at java.lang.reflect.Method.invokeNative(Native Method)
C  263.172s Main  	at
android.test.InstrumentationTestCase.runMethod(InstrumentationTestCase.java:214)
C  263.172s Main  	at
android.test.InstrumentationTestCase.runTest(InstrumentationTestCase.java:199)
C  263.172s Main  	at
android.test.ActivityInstrumentationTestCase2.runTest(ActivityInstrumentationTestCase2.java:192)
C  263.172s Main  	at
org.chromium.content_shell_apk.ContentShellTestBase.runTest(ContentShellTestBase.java:227)
C  263.172s Main  	at
android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C  263.172s Main  	at
android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C  263.172s Main  	at
android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C  263.172s Main  	at
android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)
C  263.172s Main 
********************************************************************************
C  263.172s Main  Summary
C  263.172s Main 
********************************************************************************
C  263.173s Main  [==========] 309 tests ran.
C  263.173s Main  [  PASSED  ] 306 tests.
C  263.173s Main  [  FAILED  ] 3 tests, listed below:
C  263.173s Main  [  FAILED  ]
org.chromium.content.browser.input.ImeTest#testFinishComposingText
C  263.173s Main  [  FAILED  ]
org.chromium.content.browser.input.ImeTest#testEnterKeyEventWhileComposingText
C  263.173s Main  [  FAILED  ]
org.chromium.content.browser.input.ImeTest#testKeyCodesWhileComposingText
C  263.173s Main  
C  263.173s Main  3 FAILED TESTS
C  263.173s Main 
********************************************************************************

dglazkov

6 years, 4 months ago (2014-08-20 20:38:01 UTC) #7

Message was sent while issue was closed.

On 2014/08/20 at 20:26:18, dglazkov wrote:

Nevermind. It's failing upstream in Chromium too.

Expand Messages | Collapse Messages